Repository navigation
Fix audit regressions and verify installed artifacts - #70
Merged
Merged
Conversation
Protect guide generations and SimC inputs, correct effective APL and sampled cohort semantics, extract provider services, and verify packaged and live behavior. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Select a loaded Lorrgs report for report journeys, assert inclusive Raider.IO filters against observed values, and keep SimC workflow sources separate from generated outputs while verifying collision rejection. Co-Authored-By: OpenAI Codex <noreply@openai.com>
aurokin
marked this pull request as ready for review
October 7, 2026 23:57
Exercise copied-root reuse and immutable generations without rewriting the module fixture used by later SimC handoff journeys. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial guide refreshes could overwrite bundles from completed comparisons, SimC comparisons could overwrite their inputs, and sampled analytics could combine different pulls or seasons. This patch fixes all nine audit defects, preserves earlier guide export generations, and moves Warcraft Logs discovery/readiness and Wowhead guide retrieval/export out of CLI modules. Composed guide exports now use provider functions directly.
Validation:
make checkwith the rebuilt, matching SimC binary passed: 3,599 tests and 94.78% coverage; two intentionally inapplicable HTML-provider JSON cases skipped.auth_failed, exit3); those live reads remain unverified. Redis and public Raidbots-report journeys are excluded because their required inputs are unconfigured.