Skip to content

Correct live WCL Buffs target-filter verification - #72

Merged
aurokin merged 1 commit into
mainfrom
fix/wcl-live-target-filter
Oct 10, 2026
Merged

aurokin merged 1 commit into
mainfrom
fix/wcl-live-target-filter

Conversation

@aurokin

@aurokin aurokin commented Oct 10, 2026

Copy link
Copy Markdown
Owner

The new live target-filter journey assumed that Buffs --target-id selects the raw event recipient. Warcraft Logs applies that filter to the aura caster, whose ID is sourceID in the raw event. Once public authentication was restored, the journey rejected correct upstream results.

Derive the caster from the complete baseline and compare the filtered stream against its exact source-ID subset. Keep full event equality, pagination, duplicate events, and a strict nonempty subset. Clarify the Buffs event scope in the consumer documentation.

Validation:

  • Live public WCL journeys: all three target, kill-type, and hostility checks passed with a temporary empty token-state directory. An independent live probe matched all 5,106 selected caster events out of a 50,394-event baseline.
  • Ruff and both event-pagination regressions passed.
  • Closing Diffwarden review of the corrected test and documentation found no remaining issues.
  • Local client credentials were refreshed through the Pass renderer and validated against the public API. The saved user token still returns auth_failed; user-account/private-report verification remains blocked. No credentials or token state are changed by this PR.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@aurokin
aurokin merged commit f5582d2 into main Oct 10, 2026
19 checks passed
@aurokin
aurokin deleted the fix/wcl-live-target-filter branch October 10, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant