Repository navigation
Add verified WoW Forever routing and guard incompatible handoffs - #74
Merged
Merged
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forever URLs previously had calculator-only support and failed general entity routing. This adds a verified Wowhead profile for data environment 16, scoped wrapper discovery and follow-ups, separate caches, captured source fixtures, and guide client/database provenance. All nine class calculators now have rendered comparisons.
Forever requests reject unverified provider routes, realm-dependent profile joins, and retail talent handoffs before calling providers or generating simulations. SimC identifies its actual WoW client version, reports Forever raw runs as experimental, and blocks incompatible retail build analysis. The readiness document records the official experimental engine and the evaluated WoWSims alternative.
Validation:
make checkpasses with 3,796 fast tests and 94.69% coverage; all 21 real retail SimC regressions and 14 Forever installed-binary journeys pass. The built wheel verifies all 12 installed binaries outside the checkout. An isolated official Forever engine verifies identification, usage-error boundaries, raw execution, JSON report parsing, and rejection before writing transport packets. The closing Diffwarden review has no findings after fixing the transport-validation early-return bypass.Remaining limits: no verified Forever WCL/Blizzard character contract or complete live-character simulation journey. Experimental engine execution does not establish combat accuracy. A separate WoWSims provider remains deferred pending a stable exported-request fixture and a concrete workflow.