Repository navigation
ci: ignore two historical gitleaks findings (Asana project GID) - #120
Merged
Merged
Conversation
There was a problem hiding this comment.
The PR adds two exact historical gitleaks fingerprints to .gitleaksignore, described as false positives for an Asana project GID. The exclusions are narrowly scoped to specific commits, files, rules, and lines rather than broadly disabling detection. No correctness or security problems are evident in the provided diff; overall risk is low.
Verdict: approve-worthy
Automated review by the software factory (us.openai.gpt-6.1-sol). It reads the diff only and never runs PR code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secret Boundary fails on
main(run 44148089416) and on every PR (e.g. #117) withleaks found: 2. It runsgitleaks git .after afetch-depth: 0checkout, so it scans every ref, includingfactory/infra.Both findings are
asana-client-idmatches in commiteffe2ddonfactory/infra. They're a hardcoded Asana project GID, which is a board ID and not a credential. 2cfb071 removes the value from that branch, and the stack now takes it from-c asana_project=<gid>.This PR adds a
.gitleaksignorethat skips exactly those two fingerprints (commit:file:rule:line). Every other finding still fails the job.Verified locally with gitleaks 8.30.1 and the repo config:
no leaks foundon main and on the #117 tree.