Skip to content

ci: ignore two historical gitleaks findings (Asana project GID) - #120

Merged
Robobc merged 1 commit into
mainfrom
ci/gitleaksignore-asana-gid
Nov 18, 2026
Merged

Robobc merged 1 commit into
mainfrom
ci/gitleaksignore-asana-gid

Conversation

@Robobc

@Robobc Robobc commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Secret Boundary fails on main (run 44148089416) and on every PR (e.g. #117) with leaks found: 2. It runs gitleaks git . after a fetch-depth: 0 checkout, so it scans every ref, including factory/infra.

Both findings are asana-client-id matches in commit effe2dd on factory/infra. They're a hardcoded Asana project GID, which is a board ID and not a credential. 2cfb071 removes the value from that branch, and the stack now takes it from -c asana_project=<gid>.

This PR adds a .gitleaksignore that skips exactly those two fingerprints (commit:file:rule:line). Every other finding still fails the job.

Verified locally with gitleaks 8.30.1 and the repo config: no leaks found on main and on the #117 tree.

Secret Boundary scans all fetched refs, so commit effe2dd on factory/infra
(an Asana project GID, not a credential) fails every PR and main. The
value is removed from factory/infra in 2cfb071; this skips only those two
fingerprints.

@robobc-software-factory robobc-software-factory Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds two exact historical gitleaks fingerprints to .gitleaksignore, described as false positives for an Asana project GID. The exclusions are narrowly scoped to specific commits, files, rules, and lines rather than broadly disabling detection. No correctness or security problems are evident in the provided diff; overall risk is low.

Verdict: approve-worthy

Automated review by the software factory (us.openai.gpt-6.1-sol). It reads the diff only and never runs PR code.

@Robobc
Robobc merged commit 2934a5e into main Nov 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant