Repository navigation
Conversation
thenom
requested review from
JWThewes,
eipasteur and
jeromevdl
as code owners
November 13, 2026 13:50
|
Automatically computed PR review signals (deterministic) Complexity and branch coverage help focus review on functions and their tests; these signals are advisory. Complexity and test coverage12 changed JS/TS files analyzed · 4 flagged functions.
🟢 Improving · 🟠 Needs attention · 🔴 High risk · 🟣 Highest risk — = unavailable · n/a = not applicable · * = incomplete tests Isobar repository mapThis fixed repository map locates changed files and their possible reach through static links. Signals
Legend
|
…ngs apart In a unit lane the author is told not to change other units, but the reviewer judges the lane on every finding. A finding whose fix belongs to an already-merged unit or a shared contract counts towards NOT-READY, so the lane is sent round repair turns it can't satisfy, and a stage without a gate fails with reviewer_not_ready. With review_cross_unit_findings = "advisory" (default "blocking", unchanged), a reviewer in a unit lane: - is told to put findings owned by another unit or a shared contract in a new optional submit_review field, crossUnitFindings, naming the owner, and to decide its verdict on its own unit's findings alone; - has them stored on its sensor run as detail.crossUnitFindings and shown on the timeline as v2.review.cross_unit. Repair turns and revision findings use detail.findings only, so they never reach the author. Off, outside a lane or for other roles, the prompt and tool schema are unchanged. The flag is carried through the AgentCore Gateway path (enable_mcp_gateway) as describe_changes is: session and context fields, the proxy's registration, and the tools Lambda's schema and catalogue.
thenom
force-pushed
the
feat/review-cross-unit-findings-760
branch
from
November 18, 2026 17:56
2f1d605 to
0511407
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #760
Problem
In a unit lane the author is told not to modify other units, but the stage reviewer judges the lane on every finding. A finding whose required action belongs to an already-merged unit or a shared contract counts towards NOT-READY, so the lane is sent round repair turns it can't satisfy, and a stage without a gate fails with
reviewer_not_ready.Solution
A new opt-in Terraform variable,
review_cross_unit_findings("blocking"by default, which leaves behaviour unchanged, or"advisory"), passed to the AgentCore runtime asREVIEW_CROSS_UNIT_FINDINGS. Only for a reviewer in a unit lane:findingsonly what the author can fix within this unit, to put changes owned by another unit or a shared contract incrossUnitFindingsnaming the owner, and to decide READY or NOT-READY onfindingsalone.submit_reviewgets an optionalcrossUnitFindingsfield, offered only in that scope. The trusted scope flagV2_REVIEW_CROSS_UNIT=1reaches the MCP server the same way asV2_REVIEWER_AGENT.detail.crossUnitFindingson the reviewer sensor run and emitsv2.review.cross_uniton the timeline. The repair turn and the revision findings usedetail.findingsonly, so cross-unit items never reach the author.enable_mcp_gateway): the flag is carried asdescribe_changesis: the session and context fields, the proxy's registration, the tools Lambda's schema check, and the target's catalogue (gateway-tools.json, regenerated).Off, outside a lane, or for a non-reviewer role, the prompt and tool schema are byte-identical to before (tested). No orchestrator change, so it is safe for running executions. Docs: verification axes in
docs/concepts/workflows-and-blocks.md.Known limits: it relies on the reviewer putting findings in the right field; the platform doesn't re-classify them, so a finding wrongly marked cross-unit skips repair. That's why it's opt-in. On a gated stage the cross-unit findings show on the timeline but aren't added to the gate's findings list.
User experience
No UI change. With the setting on, the timeline shows "Reviewer … recorded findings for other units" with the findings, and lanes stop being sent round repair turns for work they can't do.
Testing
review-cross-unit.test.js(brief, schema and bridge, on and off) and tworun-stage.test.jslane tests.gateway-proxy,tool-definitions,tool-gatewayandgateway-contexttests for the field; all four fail without the Gateway wiring.yjs-serverfiles, which fail to importyjsfrom the root locally, as on cleanmain.npm run lint(warnings only),npm run format:check,npm run dep:check, the pre-commit hook.fmt -check,validate -no-testswith the CI backend override, and the seven test suites as in CI exceptlambda-packaging.