Skip to content

feat(frontend): make the stage review gate easier to spot on the intent page - #792

Open
P1LOTRX wants to merge 1 commit into
aws-samples:mainfrom
P1LOTRX:feat/789-review-gate-visibility
Open

P1LOTRX wants to merge 1 commit into
aws-samples:mainfrom
P1LOTRX:feat/789-review-gate-visibility

Conversation

@P1LOTRX

@P1LOTRX P1LOTRX commented Nov 18, 2026

Copy link
Copy Markdown

Summary

Fixes #789

Problem

A stage waiting for human validation looked like any other pending gate: a plain card under "Questions for you" with a small Review stage button at the bottom.

Solution

  • GateCard: the validation gate card gets an accent border and tinted background, and a default-size Review stage button with an icon sits next to the title.
  • PendingQuestionsTabs: the section header reads "Review required" (with a matching icon) when the selected gate is a validation gate, otherwise "Questions for you".
  • IntentView: a "Waiting for review" badge in the intent header links to the review route of the first pending validation gate.

User experience

Reviewers see the header, the accented card and the badge at a glance. I have not captured a screenshot.

Testing

  • tsc -b clean; vitest for PendingQuestionsTabs.test.tsx passes (two header tests added); oxfmt applied.
  • oxlint still reports a pre-existing Date.now purity error in IntentView.tsx and warnings in RecomposePanel.tsx, neither from this change.
  • Not tested: visual rendering in a browser, the new header badge (no test added), the full test suite.

@github-actions github-actions Bot added area/frontend React application in frontend/ size/S < 200 changed lines (lockfiles excluded) labels Nov 18, 2026
github-actions Bot added a commit that referenced this pull request Nov 18, 2026
@github-actions

Copy link
Copy Markdown

Automatically computed PR review signals (deterministic)

Complexity and branch coverage help focus review on functions and their tests; these signals are advisory.

Complexity and test coverage

3 changed JS/TS files analyzed · 0 flagged functions.
Coverage unavailable; test protection cannot be compared.


Isobar repository map

PR impact map

This fixed repository map locates changed files and their possible reach through static links.
Red marks changed files; green marks static links, not proven runtime impact or a risk grade.

Isobar by r3al1tym.

Signals
  • A: frontend/src/components/intent/GateCard.tsx — modified file · no static reach detected.
  • B: frontend/src/pages/IntentView.tsx — modified file · 6 file-level import-link targets.
  • Total static reach: 2 unchanged production files; 4 unchanged test files.
  • Revision: 9b9a091; updated 2026-11-18 17:36 UTC.
Legend
  • ○ modified · ◇ added · × deleted. Blue markers: tests; gray markers: documentation.
  • Solid green: import-linked name matches. Dotted green: broader file-level import fallback.

Full report artifacts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend React application in frontend/ size/S < 200 changed lines (lockfiles excluded)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Make the stage review gate easier to spot on the intent page

1 participant