Skip to content

fix: remediate CodeQL scan findings - #5

Merged
khanrubd merged 1 commit into
mainfrom
develop
Nov 12, 2026
Merged

khanrubd merged 1 commit into
mainfrom
develop

Conversation

@khanrubd

Copy link
Copy Markdown
Contributor
  • minimatch 10.2.6 (transitive dev dependency of eslint and
    typescript-eslint) is affected by GHSA-g3hv-75wg-m249. No eslint or
    typescript-eslint release yet depends on a patched minimatch, so the
    fixed version is forced with an exact npm override and the lock is
    regenerated. Lint output is unchanged under 11.0.8.

  • frontend, e2e fixtures: draw session-id fallback, idempotency keys,
    event keys and test run ids from crypto.getRandomValues via a shared
    randomToken helper (one per npm project); Math.random is removed and a
    unit test forbids it returning.

  • scripts: rewrite three regexes with ambiguous whitespace into
    equivalent linear forms (SSE union parser, iam_roles string-list
    locals, route_invoke_arns contract test), each pinned by tests.

  • CloudFront smoke and CSP tests: accept script end tags with trailing
    content and any case; a guard pins index.html's literal tag forms.

  • tests: replace host-substring assertions with exact-output, anchored
    grant-line and parsed-hostname assertions.

  • relay tests: build the non-Bearer Basic header fixture at runtime.

  • test_no_math_random: run git through scripts.proc_run instead of a
    direct subprocess call, as check_subprocess_funnel requires.

  • test_e2e_browser_scaffold: apply the extractor sanity check only to
    sources that contain an import or re-export statement, so an
    import-free fixture passes while a missed import still fails.

- minimatch 10.2.6 (transitive dev dependency of eslint and
  typescript-eslint) is affected by GHSA-g3hv-75wg-m249. No eslint or
  typescript-eslint release yet depends on a patched minimatch, so the
  fixed version is forced with an exact npm override and the lock is
  regenerated. Lint output is unchanged under 11.0.8.

- frontend, e2e fixtures: draw session-id fallback, idempotency keys,
  event keys and test run ids from crypto.getRandomValues via a shared
  randomToken helper (one per npm project); Math.random is removed and a
  unit test forbids it returning.

- scripts: rewrite three regexes with ambiguous whitespace into
  equivalent linear forms (SSE union parser, iam_roles string-list
  locals, route_invoke_arns contract test), each pinned by tests.

- CloudFront smoke and CSP tests: accept script end tags with trailing
  content and any case; a guard pins index.html's literal tag forms.

- tests: replace host-substring assertions with exact-output, anchored
  grant-line and parsed-hostname assertions.

- relay tests: build the non-Bearer Basic header fixture at runtime.

- test_no_math_random: run git through scripts.proc_run instead of a
  direct subprocess call, as check_subprocess_funnel requires.

- test_e2e_browser_scaffold: apply the extractor sanity check only to
  sources that contain an import or re-export statement, so an
  import-free fixture passes while a missed import still fails.
@khanrubd
khanrubd merged commit a8347d5 into main Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant