EKS node diagnostics MCP: human-in-the-loop collection approval#35
Open
shyamkulkarni wants to merge 1 commit into
Open
EKS node diagnostics MCP: human-in-the-loop collection approval#35shyamkulkarni wants to merge 1 commit into
shyamkulkarni wants to merge 1 commit into
Conversation
…proval Remove the restricted tcpdump_capture/tcpdump_analyze tools and gate the two mutating tools (collect, batch_collect) behind an out-of-band human approval flow instead: - Approval Lambda + Function URL with capability-URL tokens (SHA-256 stored server-side, single-use, DynamoDB TTL expiry) - SNS topic notifies approvers with approve/deny links - batch_collect defaults to dry-run - Stricter EKS instance validation: user-settable kubernetes.io/cluster/* tag rejected unless ALLOW_SELF_MANAGED_NODES=true - ReDoS-safe search regex validation and log-key path checks - Update README, architecture docs, and runbooks accordingly - Add pytest coverage for the approval flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #27. Replaces the restricted tcpdump tools with a human-in-the-loop approval flow for the two mutating tools (
collect,batch_collect):tcpdump_capture/tcpdump_analyzeand theENABLED_RESTRICTED_TOOLSmechanism (21 tools -> 19)collectcall writes a PENDING record to DynamoDB and notifies approvers via SNS with a single-use capability URL (only the SHA-256 of the token is stored server-side); the agent re-calls with theapprovalIdafter human approvalbatch_collectnow defaults to dry-runkubernetes.io/cluster/*tag is rejected unlessALLOW_SELF_MANAGED_NODES=true(cross-checked via EKS API)Testing
npm run build(tsc) passestests/test_collection_approval.pycovering the approval flow)