Conversation
|
Hi! Just a friendly follow-up on this PR. All checks are passing, and the installed-tarball smoke test covers the regression reported in #2125. Please let me know if any changes are needed. Thanks! |
|
Hi @nborges-aws, sorry for the direct ping. This community PR seems to be waiting on maintainer approval for the fork workflows and the required team review. Would you mind taking a look or routing it to the appropriate reviewer when you have a chance? It fixes the TypeScript CodeZip packaging regression reported in #2125 by keeping Thanks! |
|
Hi @nborges-aws, I took a look at the ongoing The refactored CLI itself now builds with Bun, and the generated CDK project delegates deployment/packaging through Given that, would you still like this bug fix merged into I'm happy to update or close the PR depending on the intended maintenance path. Thanks! |
Description
TypeScript CodeZip packaging invokes esbuild at runtime. However, the CLI build bundles esbuild's JavaScript API, causing
agentcore packageto fail with:This PR:
esbuildto the CLI build'sexternallist.esbuildfromdevDependenciestodependenciesand updatesnpm-shrinkwrap.jsonwithout changing the version range.TestRuntime.zipis generated.Both dependency changes are necessary: externalizing esbuild prevents it from being bundled into the CLI, while declaring it as a production dependency makes it available after installation.
The existing global tarball installation step is unchanged. The fixture has no application dependencies and exists only to exercise TypeScript packaging.
Related Issue
Closes #2125
Documentation PR
N/A — this fixes package distribution without changing the public CLI interface.
Type of Change
Testing
Validation was performed on macOS with Node.js
v24.15.0.npm run test:unit— 428 test files passed; 6,150 tests passed.npm run test:integ— 34 test files passed; 342 tests passed and 1 test skipped.npm run typecheck— passed.npm run lint— completed with 0 errors and 32 warnings.src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshots — N/A; no files undersrc/assets/were modified.All reported lint warnings are in files not modified by this PR. No additional lint warnings were observed compared with main.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.