Conversation
The org's shared ubuntu-latest pool never picked up the publish job. Trusted publishing works from the CodeBuild runner, provenance is only signed on GitHub-hosted runners, so the flag goes until a hosted runner is available.
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
CI-only change. Two things happen together:
check-releaseandpublishjobs move fromubuntu-latestto the ephemeral CodeBuild runner labels (["codebuild-agentcore-e2e-…", "verify-linux"]), matching the pattern already used inverify.yml,codeql.yml, andpr-automation.yml.--provenanceis dropped fromnpm publishbecause npm only signs provenance on GitHub-hosted runners. Trusted publishing still works — theid-token: writepermission and OIDC flow are unchanged — so authentication to npm is preserved; only the sigstore attestation is lost.
The tradeoff is documented in-place at lines 55–56, and there are no consumers in the repo that depend on provenance metadata. Nothing blocking.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
jariy17
marked this pull request as draft
September 21, 2026 18:34
jariy17
marked this pull request as ready for review
September 21, 2026 18:35
tejaskash
force-pushed
the
ci/release-on-codebuild
branch
from
September 22, 2026 18:56
a29d001 to
1fc9937
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2342 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nborges-aws
previously approved these changes
Sep 22, 2026
tejaskash
force-pushed
the
ci/release-on-codebuild
branch
from
September 22, 2026 19:06
1fc9937 to
a29d001
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
check-releaseandpublishrun on the CodeBuild Linux label thatverifyuses.npm publishdrops--provenance.Why
The rc.3 publish dispatched at 19:42 has sat queued on
ubuntu-latestsince; theawsorg's hosted Linux pool is not serving this repo. Trusted publishing (OIDC) works from self-hosted runners, provenance attestations are only signed on GitHub-hosted ones, so rc.3 publishes without an attestation. Restore--provenanceonceaws-release-4-coreallowlists this workflow file.How tested
Workflow parses and passes prettier. Exercised by the rc.3 dispatch after merge.