Skip to content

ci(release): publish from the CodeBuild runner without provenance - #2342

Open
tejaskash wants to merge 1 commit into
refactorfrom
ci/release-on-codebuild
Open

tejaskash wants to merge 1 commit into
refactorfrom
ci/release-on-codebuild

Conversation

@tejaskash

@tejaskash tejaskash commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

What

check-release and publish run on the CodeBuild Linux label that verify uses. npm publish drops --provenance.

Why

The rc.3 publish dispatched at 19:42 has sat queued on ubuntu-latest since; the aws org's hosted Linux pool is not serving this repo. Trusted publishing (OIDC) works from self-hosted runners, provenance attestations are only signed on GitHub-hosted ones, so rc.3 publishes without an attestation. Restore --provenance once aws-release-4-core allowlists this workflow file.

How tested

Workflow parses and passes prettier. Exercised by the rc.3 dispatch after merge.

The org's shared ubuntu-latest pool never picked up the publish job. Trusted
publishing works from the CodeBuild runner, provenance is only signed on
GitHub-hosted runners, so the flag goes until a hosted runner is available.
@github-actions github-actions Bot added the size/xs PR size: XS label Sep 18, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 18, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

CI-only change. Two things happen together:

  1. check-release and publish jobs move from ubuntu-latest to the ephemeral CodeBuild runner labels (["codebuild-agentcore-e2e-…", "verify-linux"]), matching the pattern already used in verify.yml, codeql.yml, and pr-automation.yml.
  2. --provenance is dropped from npm publish because npm only signs provenance on GitHub-hosted runners. Trusted publishing still works — the id-token: write permission and OIDC flow are unchanged — so authentication to npm is preserved; only the sigstore attestation is lost.

The tradeoff is documented in-place at lines 55–56, and there are no consumers in the repo that depend on provenance metadata. Nothing blocking.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 18, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 18, 2026
@jariy17
jariy17 marked this pull request as draft September 21, 2026 18:34
@jariy17
jariy17 marked this pull request as ready for review September 21, 2026 18:35
@tejaskash
tejaskash force-pushed the ci/release-on-codebuild branch from a29d001 to 1fc9937 Compare September 22, 2026 18:56
@tejaskash tejaskash changed the title ci(release): publish from the CodeBuild runner without provenance ci(release): run release jobs on CodeBuild and skip macOS Sep 22, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (f86a13d) to head (1fc9937).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2342   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
=========================================
  Files           613      613           
  Lines         41028    41028           
=========================================
  Hits          39902    39902           
  Misses         1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nborges-aws
nborges-aws previously approved these changes Sep 22, 2026
@tejaskash
tejaskash force-pushed the ci/release-on-codebuild branch from 1fc9937 to a29d001 Compare September 22, 2026 19:06
@tejaskash tejaskash changed the title ci(release): run release jobs on CodeBuild and skip macOS ci(release): publish from the CodeBuild runner without provenance Sep 22, 2026
@github-actions github-actions Bot added size/xs PR size: XS and removed size/s PR size: S size/xs PR size: XS labels Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants