feat(payment): add connector credential rotation - #2343
Draft
aidandaly24 wants to merge 3 commits into
Draft
aidandaly24 wants to merge 3 commits into
aidandaly24 wants to merge 3 commits into
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, additive change that fits cleanly with the existing payment connector command family:
- Handler mirrors the shape of the sibling
get/listcommands, and mocks at the AWS SDK client boundary (no over-mocking). - Zod validation covers the enum values, minimum selection, and duplicate rejection — the negative tests exercise all three.
- Both single-secret and combined-secret paths are covered, plus error propagation.
- Docs call out the non-atomicity and wallet-secret disruption risk, which is the right place to surface it for a command that has no TUI confirmation step.
Minor observations (non-blocking, author's call):
- The test lives in
payment.read.test.tsxbut rotation is a mutating call; if you care about the naming split you may want to move the new cases into apayment.write.test.tsx(or rename the file). Not required. - No telemetry instrumentation, but the sibling read commands don't emit any either — consistent with the current payment surface.
Nothing here needs to change before merging.
aidandaly24
marked this pull request as ready for review
September 21, 2026 22:49
aidandaly24
marked this pull request as draft
September 21, 2026 22:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one headless command:
This targets
refactorafter #2276 merged. It does not include the parked CUD PRs or TUI work.No IAM provisioning, OAuth wizard, polling, custom retries, or custom signing is added.
Blocking SDK Dependency
Draft only. Do not merge: this branch currently cannot typecheck or start the CLI.
The verified operation contract requires the following SDK exports, which are absent from both
the lockfile SDK and the latest published control-plane SDK checked, 3.1136.0:
RotatePaymentConnectorCredentialsCommandRotatePaymentConnectorCredentialsRequestRotatePaymentConnectorCredentialsResponseCoinbaseCdpSecretThe implementation uses those expected generated exports directly. There is no invented version pin,
vendored SDK, declaration patch, or compatibility shim. The SDK version and lockfile update remain
pending until a release containing the operation is available.
Validation
Baseline at
a23e4729:for the missing rotation command/tree entry.
Current draft:
git diff --check, and bundling pass.runtime validation because the SDK is external to the bundle.
Before Ready For Review
both, token replay, and actual post-rotation credential usability.