ci(release): skip macOS verification - #2387
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
The refactor is well-reasoned and the diff is small and self-contained.
- The matrix
exclude-can't-drop-includelimitation is real, and pulling macOS out into a separate job gated by aninputs.macosboolean is the standard way to make a platform conditionally skippable in a reusable workflow. The inline comment captures the constraint clearly. ci.ymldoesn't passmacos, so PR/CI runs still cover Linux, Windows, and macOS via thedefault: true.release-main-and-preview.ymlexplicitly setsmacos: false, matching the intent from #2381.needs: verifyin the publish job correctly references the reusable-workflow caller job; a skippedverify-macoswon't fail the parent, and a failure would still block publish.- Workflow-level
AGENTCORE_TELEMETRY_DISABLED,persist-credentials: false, and least-privilegecontents: readare preserved in the new job. Codecov still only uploads from Linux.
Minor observation, not a blocker: the new macOS job runs bun test without --coverage, and duplicates the build/pack/compile/smoke-test steps from the matrix. That's a deliberate tradeoff of the "job per platform via if" approach and is fine as-is.
Nothing that needs to change before merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2387 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
What
Moves the macOS verification into its own job in the reusable verify workflow, gated by a new
macosinput that defaults to true. The release workflow passesmacos: false. CI keeps all three platforms.Why
#2381 tried to drop macOS from release with a matrix
exclude. GitHub rejects anexcludekey that is not a matrix dimension, andexcluderuns beforeinclude, so it can never remove an include entry. The workflow failed to materialize and #2385 reverted it. A separate job with anifis the only way to skip a platform by input.How tested