Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
CI-only change; logic verified end-to-end:
matrix.targetis derived directly fromfromJSON(inputs.skip_macos && '[...]' || '[...]'), avoiding theinclude/excludeinteraction that broke #2381.nameandruns-onexpressions correctly resolve for all three targets (linux-x64→ Linux/CodeBuild-linux,windows-x64→ Windows/CodeBuild-windows,darwin-arm64→ macOS/macos-latest via the||fallback).- Smoke test path
./dist/bin/agentcore-${{ matrix.target }}${{ matrix.target == 'windows-x64' && '.exe' || '' }}reproduces the previous per-target binaries. skip_macos: trueis only passed fromrelease-main-and-preview.yml, so regular PR CI still verifies macOS. The macOS binary itself is still compiled onubuntu-latestin thepublishjob and uploaded to the release, so skipping the macOS verify leg doesn't drop the darwin-arm64 artifact — only the on-macOS smoke test and unit tests, which is a reasonable tradeoff to unblock releases from flaky macOS runners.
One low-priority maintenance note (non-blocking): the name/runs-on fallback arms both default to macOS, so any future fourth target would silently be labeled/routed as macOS until those expressions are updated. Fine to leave as-is given the target list is right there in the matrix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2388 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
What
Release verification can remain blocked waiting for the macOS runner after Linux and Windows have passed, as in run 35777299022.
skip_macosinput to the reusable verification workflow, defaulting tofalse.exclude.skip_macos: trueonly in the release-publish workflow. Regular CI continues to verify Linux, Windows, and macOS.Why
The earlier attempt in #2381 used a dynamic
excludewith an include-only matrix. That caused verification jobs to stop materializing and was reverted in #2385.This version does not use
includeorexcludeto select platforms. The release caller produces a Linux/Windows target array, while callers using the default produce Linux/Windows/macOS.Validation
actionlint1.7.12 on both changed workflowsgit diff --check