Skip to content

fix(e2e): bump timeout for local invokes - #2389

Merged
Hweinstock merged 1 commit into
aws:refactorfrom
Hweinstock:fix/e2e
Sep 22, 2026
Merged

Hweinstock merged 1 commit into
aws:refactorfrom
Hweinstock:fix/e2e

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

The retry for local dev startup time is capped at 10 seconds by default.

timeoutMs = 10_000,

Solution

Bump this time capped to the invoke timeout which is 3 minutes.

Verification

ran the tests locally

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, targeted fix. The retry(...) call in the local-invoke test was falling back to the helper's default 10 s timeout, which is well below the outer PROJECT_INVOKE test timeout (3 min) and almost certainly the source of flakiness while the local dev server warms up. Passing TIMEOUT_MS.PROJECT_INVOKE aligns the inner retry deadline with the surrounding test timeout.

One thing worth being aware of (not blocking): the retry deadline now equals the test timeout, so in a true hang the vitest timeout may fire first and mask the retry's lastError. In practice retry throws slightly before the test timeout since work has already happened before entering it, so this is fine — but if you ever want cleaner failure messages you could pass something like TIMEOUT_MS.PROJECT_INVOKE - 5_000.

Nothing needs to change to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 22, 2026
@tejaskash
tejaskash marked this pull request as ready for review September 22, 2026 20:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (ae18e6c) to head (4bd62ce).
⚠️ Report is 7 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2389   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
=========================================
  Files           613      613           
  Lines         41028    41028           
=========================================
  Hits          39902    39902           
  Misses         1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hweinstock
Hweinstock merged commit d301aac into aws:refactor Sep 22, 2026
19 of 23 checks passed
@Hweinstock
Hweinstock deleted the fix/e2e branch September 22, 2026 20:29
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the report, @codecov-commenter — feedback like this is exactly
how we catch the things we missed. Because this PR is already
closed, the team won't see follow-up comments here.

Would you mind opening a new issue so we can track it properly?
https://github.com/aws/agentcore-cli/issues/new/choose

If this is a security issue, please report it privately via
https://aws.amazon.com/security/vulnerability-reporting/ instead
of a public issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants