fix(e2e): bump timeout for local invokes - #2389
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, targeted fix. The retry(...) call in the local-invoke test was falling back to the helper's default 10 s timeout, which is well below the outer PROJECT_INVOKE test timeout (3 min) and almost certainly the source of flakiness while the local dev server warms up. Passing TIMEOUT_MS.PROJECT_INVOKE aligns the inner retry deadline with the surrounding test timeout.
One thing worth being aware of (not blocking): the retry deadline now equals the test timeout, so in a true hang the vitest timeout may fire first and mask the retry's lastError. In practice retry throws slightly before the test timeout since work has already happened before entering it, so this is fine — but if you ever want cleaner failure messages you could pass something like TIMEOUT_MS.PROJECT_INVOKE - 5_000.
Nothing needs to change to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2389 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the report, @codecov-commenter — feedback like this is exactly Would you mind opening a new issue so we can track it properly? If this is a security issue, please report it privately via |
Problem
The retry for local dev startup time is capped at 10 seconds by default.
agentcore-cli/e2eTest/helpers/retry.ts
Line 4 in 484fdde
Solution
Bump this time capped to the invoke timeout which is 3 minutes.
Verification
ran the tests locally