Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped change to avoid re-running verify and e2e on release pushes since release-publish already verifies before publishing. The comment above verify explains the intent clearly.
A couple of minor things worth noting (not blocking):
- The skip relies on the push's
head_commit.messagestarting withchore(release):. This works for squash merges (which the repo appears to use — the PR titlechore(release): v$VERSIONfromrelease-prepare.ymlis preserved as the squash commit) and rebase merges, but would not match if a release PR were ever merged via a "Create a merge commit" strategy (Merge pull request #...). Givenrelease-prepare.ymlproduces a PR with that exact title and the repo squashes, this should be fine in practice. check-releaseinrelease-main-and-preview.ymlidentifies release pushes structurally (merged PR from the release bot with arelease/vhead branch and matchingmerge_commit_sha), which is stricter than the message-based check here. That divergence is acceptable — the CI skip is an optimization, whilerelease-publishneeds to be authoritative — but worth being aware of if the release commit message format ever changes.
Neither is a real problem; safe to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2393 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: no high-confidence findings. (run) |
|
|
||
| e2e: | ||
| if: github.event_name == 'push' | ||
| if: >- |
There was a problem hiding this comment.
i don't think these are run as part of the release workflow (yet) so release publish would never run e2e tests.
Description
Release merges such as #2391 trigger both CI and release publishing, duplicating Linux and Windows verification. Skip CI's
verifyande2ejobs only when a push's head commit message starts withchore(release):and its author username isagentcore-devx-automation[bot].Both conditions are evaluated directly from the push payload. This checks commit authorship; it does not verify the associated PR. Ordinary pushes, PR verification, and manual CI verification retain their existing behavior.
Release publishing remains unchanged and runs its own Linux and Windows verification before publishing. CI's macOS and E2E checks also skip matching release pushes. GitHub still creates a skipped CI workflow entry.
Related Issue
Closes #2392
Documentation PR
Not applicable; workflow-only change, with an explanatory comment in
ci.yml.Type of Change
Testing
Passed YAML parsing, Prettier validation for
.github/workflows/ci.yml, andgit diff --check. Confirmed via the GitHub commit API that release commitbafd09eis authored byagentcore-devx-automation[bot]. Reviewed both conditions for matching release pushes, other authors, ordinary commit messages, PR events, and manual dispatch. The updated conditions have not been exercised on a release push. Application tests, typechecking, linting, and build were not run because this change only modifies workflow conditions. E2E tests are not applicable to this workflow-only change.bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.