Skip to content

ci: skip CI jobs for bot-authored release pushes - #2393

Open
jariy17 wants to merge 3 commits into
aws:refactorfrom
jariy17:fix/skip-release-push-ci
Open

jariy17 wants to merge 3 commits into
aws:refactorfrom
jariy17:fix/skip-release-push-ci

Conversation

@jariy17

@jariy17 jariy17 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Description

Release merges such as #2391 trigger both CI and release publishing, duplicating Linux and Windows verification. Skip CI's verify and e2e jobs only when a push's head commit message starts with chore(release): and its author username is agentcore-devx-automation[bot].

Both conditions are evaluated directly from the push payload. This checks commit authorship; it does not verify the associated PR. Ordinary pushes, PR verification, and manual CI verification retain their existing behavior.

Release publishing remains unchanged and runs its own Linux and Windows verification before publishing. CI's macOS and E2E checks also skip matching release pushes. GitHub still creates a skipped CI workflow entry.

Related Issue

Closes #2392

Documentation PR

Not applicable; workflow-only change, with an explanatory comment in ci.yml.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): CI workflow optimization

Testing

Passed YAML parsing, Prettier validation for .github/workflows/ci.yml, and git diff --check. Confirmed via the GitHub commit API that release commit bafd09e is authored by agentcore-devx-automation[bot]. Reviewed both conditions for matching release pushes, other authors, ordinary commit messages, PR events, and manual dispatch. The updated conditions have not been exercised on a release push. Application tests, typechecking, linting, and build were not run because this change only modifies workflow conditions. E2E tests are not applicable to this workflow-only change.

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, well-scoped change to avoid re-running verify and e2e on release pushes since release-publish already verifies before publishing. The comment above verify explains the intent clearly.

A couple of minor things worth noting (not blocking):

  • The skip relies on the push's head_commit.message starting with chore(release):. This works for squash merges (which the repo appears to use — the PR title chore(release): v$VERSION from release-prepare.yml is preserved as the squash commit) and rebase merges, but would not match if a release PR were ever merged via a "Create a merge commit" strategy (Merge pull request #...). Given release-prepare.yml produces a PR with that exact title and the repo squashes, this should be fine in practice.
  • check-release in release-main-and-preview.yml identifies release pushes structurally (merged PR from the release bot with a release/v head branch and matching merge_commit_sha), which is stricter than the message-based check here. That divergence is acceptable — the CI skip is an optimization, while release-publish needs to be authoritative — but worth being aware of if the release commit message format ever changes.

Neither is a real problem; safe to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 22, 2026
@codecov-commenter

codecov-commenter commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (bafd09e) to head (bce4896).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2393   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
=========================================
  Files           613      613           
  Lines         41028    41028           
=========================================
  Hits          39902    39902           
  Misses         1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jariy17 jariy17 changed the title ci: skip CI jobs for release pushes ci: skip CI jobs for confirmed bot release merges Sep 22, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/xs PR size: XS size/s PR size: S labels Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@jariy17 jariy17 changed the title ci: skip CI jobs for confirmed bot release merges ci: skip CI jobs for bot-authored release pushes Sep 22, 2026
@github-actions github-actions Bot added size/xs PR size: XS and removed size/s PR size: S size/xs PR size: XS labels Sep 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 22, 2026
Comment thread .github/workflows/ci.yml

e2e:
if: github.event_name == 'push'
if: >-

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think these are run as part of the release workflow (yet) so release publish would never run e2e tests.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants