chore(e2e): add logs to determine source of failure - #2394
Hweinstock wants to merge 2 commits into
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused diagnostic PR that adds error logs before each throw inside the retry block in e2eTest/project/templates.test.ts, plus a lightweight TestLogger helper. Purpose (root-causing the py_strands_container CI-only failure) is clear and the change is scoped to e2e tests only. No production code, no telemetry surface, and no new mocks.
One non-blocking observation the author may want to consider as a follow-up: the logger.error(pendingOutput) calls sit inside the retry(...) callback, which retries every 250ms up to TIMEOUT_MS.PROJECT_INVOKE. In particular the !port branch is the expected state while the dev server warms up, so on a slow CI run this will emit the full pending output on every attempt — potentially a lot of duplicated log noise. Logging only the final failure (e.g. by having retry surface the last error to the caller, or by moving the diagnostic dump into a catch around the retry call) would give the same signal with less noise. Fine to land as-is for the immediate debugging need.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2394 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 613 613
Lines 41028 41028
=========================================
Hits 39902 39902
Misses 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e820d27 to
5134537
Compare
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: no high-confidence findings. (run) |
Problem
The strands py container test is failing in CI only (passes locally) and we are missing sufficient logs to determine the source:
Solution
Add some error details to be able to root cause the issue.