test(tui): inline imperative screen configuration - #2401
Closed
aidandaly24 wants to merge 5 commits into
Closed
aidandaly24 wants to merge 5 commits into
aidandaly24 wants to merge 5 commits into
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2401 +/- ##
=========================================
Coverage 97.25% 97.25%
=========================================
Files 612 612
Lines 41019 41019
=========================================
+ Hits 39893 39894 +1
+ Misses 1126 1125 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Sep 24, 2026
Hweinstock
approved these changes
Sep 24, 2026
aidandaly24
marked this pull request as ready for review
September 24, 2026 23:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
renderImperativeScreenwith ordinaryrenderScreencalls that pass their configuration explicitly. This makes each test's opt-in visible and removes the wrapper's implicit enabled default. The shared config value remains, existing explicit overrides are preserved, and production behavior is unchanged.Related Issue
Refs #2400. Follow-up to #2396.
Documentation PR
Not applicable: test-only refactoring.
Type of Change
Testing
3,563 tests passed with 98.00% line coverage. Structural comparison verified 323 migrated calls: 320 explicit defaults, three preserved overrides, and no changes to the 16 pre-existing ordinary
renderScreencalls in affected files.bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themDeployment E2E tests are not applicable because this only changes test setup. Existing CLI and TUI behavior tests ran in the full suite. No assets changed.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.