Skip to content

test(tui): inline imperative screen configuration - #2401

Closed
aidandaly24 wants to merge 5 commits into
aws:refactorfrom
aidandaly24:test/inline-imperative-screen-config
Closed

aidandaly24 wants to merge 5 commits into
aws:refactorfrom
aidandaly24:test/inline-imperative-screen-config

Conversation

@aidandaly24

Copy link
Copy Markdown
Contributor

Description

Replace renderImperativeScreen with ordinary renderScreen calls that pass their configuration explicitly. This makes each test's opt-in visible and removes the wrapper's implicit enabled default. The shared config value remains, existing explicit overrides are preserved, and production behavior is unchanged.

Related Issue

Refs #2400. Follow-up to #2396.

Documentation PR

Not applicable: test-only refactoring.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): simplify test setup.

Testing

3,563 tests passed with 98.00% line coverage. Structural comparison verified 323 migrated calls: 320 explicit defaults, three preserved overrides, and no changes to the 16 pre-existing ordinary renderScreen calls in affected files.

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Deployment E2E tests are not applicable because this only changes test setup. Existing CLI and TUI behavior tests ran in the full suite. No assets changed.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xl PR size: XL label Sep 24, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 24, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Sep 24, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (7d8f74d) to head (8469927).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2401   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
=========================================
  Files           612      612           
  Lines         41019    41019           
=========================================
+ Hits          39893    39894    +1     
+ Misses         1126     1125    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aidandaly24
aidandaly24 marked this pull request as ready for review September 24, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants