Skip to content

Revert "feat(invoke): overload invoke for project and existing Runtim… - #2427

Closed
Hweinstock wants to merge 1 commit into
aws:refactorfrom
Hweinstock:revert/combine-invoke
Closed

Hweinstock wants to merge 1 commit into
aws:refactorfrom
Hweinstock:revert/combine-invoke

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

This reverts the earlier the commit to combine invoke into one command: #2399.

We have decided to keep these separate and under the resource based commands.

git revert ...

@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Sep 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 28, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

This is a clean git revert of PR #2399. I diffed the touched files against the pre-#2399 baseline (86d7c81e) and got zero delta across src/handlers/**/invoke/, src/handlers/utils.*, src/handlers/project/{selection,types}.*, src/middleware/withProject.tsx, src/router/**, src/core/project/**, README.md, command.md, the template READMEs, and the e2e test — so this restores previously-reviewed and shipped code exactly.

A few things worth flagging for the author to double-check before merge, not code issues:

  • BREAKING CHANGE going out again. #2399 landed with a BREAKING CHANGE footer for invoke runtime/invoke harness/runtime invoke/harness invoke/gateway invoke. Reverting reintroduces the subcommand shape, which is another breaking change relative to the current released surface. Consider marking the commit/PR accordingly (and calling it out in the changelog / release notes) so downstream users get an explicit signal rather than a silent flip back.
  • gateway invoke project integration is gone again. The revert drops project-aware gateway invocation (picker no longer lists Gateways, resolveDeployedResources no longer emits gateways, invoke.screen.test.tsx loses the gateway case). That matches the pre-#2399 state, but if any users have started relying on invoke --gateway <project-name> since #2399 shipped, they'll lose that path. Worth confirming that's intended.
  • No new telemetry needed since no new behavior is being introduced — just restoring the prior instrumentation surface.

Otherwise, LGTM — nothing to change in the diff.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 28, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.38337% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.25%. Comparing base (52f9990) to head (b09ec2d).

Files with missing lines Patch % Lines
src/handlers/project/invoke/runtime.tsx 97.92% 5 Missing ⚠️
src/handlers/project/invoke/harness.tsx 98.59% 1 Missing ⚠️
src/handlers/project/invoke/index.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2427      +/-   ##
============================================
- Coverage     97.28%   97.25%   -0.04%     
============================================
  Files           611      612       +1     
  Lines         40954    40986      +32     
============================================
+ Hits          39842    39860      +18     
- Misses         1112     1126      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hweinstock
Hweinstock marked this pull request as ready for review September 28, 2026 15:51
@Hweinstock Hweinstock closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants