Revert "feat(invoke): overload invoke for project and existing Runtim… - #2427
Hweinstock wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This is a clean git revert of PR #2399. I diffed the touched files against the pre-#2399 baseline (86d7c81e) and got zero delta across src/handlers/**/invoke/, src/handlers/utils.*, src/handlers/project/{selection,types}.*, src/middleware/withProject.tsx, src/router/**, src/core/project/**, README.md, command.md, the template READMEs, and the e2e test — so this restores previously-reviewed and shipped code exactly.
A few things worth flagging for the author to double-check before merge, not code issues:
- BREAKING CHANGE going out again. #2399 landed with a
BREAKING CHANGEfooter forinvoke runtime/invoke harness/runtime invoke/harness invoke/gateway invoke. Reverting reintroduces the subcommand shape, which is another breaking change relative to the current released surface. Consider marking the commit/PR accordingly (and calling it out in the changelog / release notes) so downstream users get an explicit signal rather than a silent flip back. gateway invokeproject integration is gone again. The revert drops project-aware gateway invocation (picker no longer lists Gateways,resolveDeployedResourcesno longer emits gateways,invoke.screen.test.tsxloses the gateway case). That matches the pre-#2399 state, but if any users have started relying oninvoke --gateway <project-name>since #2399 shipped, they'll lose that path. Worth confirming that's intended.- No new telemetry needed since no new behavior is being introduced — just restoring the prior instrumentation surface.
Otherwise, LGTM — nothing to change in the diff.
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor #2427 +/- ##
============================================
- Coverage 97.28% 97.25% -0.04%
============================================
Files 611 612 +1
Lines 40954 40986 +32
============================================
+ Hits 39842 39860 +18
- Misses 1112 1126 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reverts the earlier the commit to combine invoke into one command: #2399.
We have decided to keep these separate and under the resource based commands.
git revert ...