fix(cloudformation): Cap CloudFormation LSP server heap at 384MB - #8837
Open
chrisqm-dev wants to merge 1 commit into
Open
fix(cloudformation): Cap CloudFormation LSP server heap at 384MB#8837chrisqm-dev wants to merge 1 commit into
chrisqm-dev wants to merge 1 commit into
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
chrisqm-dev
changed the title
chrisqm-dev
changed the title
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Set NODE_OPTIONS --max-old-space-size=384 when spawning the CloudFormation language server process. Without this, V8 uses its default ~4GB ceiling and the process grows unbounded — field data shows the server's main heap runs 100–200MB so 384MB gives ~2x headroom while preventing runaway growth from consuming the IDE's memory budget. Complements cloudformation-languageserver server-side optimizations (cfn-lint-disabled early exit, worker thread heap caps, orphan process fix). aws/aws-toolkit-jetbrains#6380
chrisqm-dev
force-pushed
the
perf/cfn-lsp-memory-limits
branch
from
July 23, 2026 14:28
ae4e848 to
949222b
Compare
|
Zee2413
reviewed
Jul 23, 2026
|
|
||
| const envOptions = { | ||
| NODE_OPTIONS: '--enable-source-maps', | ||
| NODE_OPTIONS: '--enable-source-maps --max-old-space-size=384', |
Contributor
There was a problem hiding this comment.
Is --enable-source-maps support to help with the memory issue?
satyakigh
suggested changes
Jul 31, 2026
satyakigh
left a comment
satyakigh
left a comment
Contributor
There was a problem hiding this comment.
Change needs to be validated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
NODE_OPTIONS --max-old-space-size=384when spawning the CloudFormation language server process. Without this, V8 uses its default ~4GB ceiling and the process grows unboundedThis is to partially address memory consumption issues of the language server: aws/aws-toolkit-jetbrains#6380
The original issue was for jetbrains but it is applicable to the vscode client as well.
feature/xbranches will not be squash-merged at release time.