fix(smus): Make AWS partition and endpoint handling GovCloud-resilient - #8843
Open
ziwikiwi wants to merge 1 commit into
Open
fix(smus): Make AWS partition and endpoint handling GovCloud-resilient#8843ziwikiwi wants to merge 1 commit into
ziwikiwi wants to merge 1 commit into
Conversation
Local IDE hardcoded the commercial `aws` partition and `.amazonaws.com`
DNS suffix in several ARN and endpoint constructions, which break in
GovCloud (aws-us-gov partition). Route these through the existing
regionProvider (getPartitionId / getDnsSuffixForRegion) so they resolve
correctly per partition.
- smusUtils.extractAccountIdFromSageMakerArn: match any partition
(arn:aws[a-z-]*:) instead of literal arn:aws:
- detached-server parseArn: match any partition
- detached-server startSagemakerSession: only override the endpoint when
SAGEMAKER_ENDPOINT is set; otherwise let the SDK resolver derive the
partition-correct host (this file cannot import vscode/globals)
- sqlWorkbenchClient: derive partition for the ARN and dnsSuffix for the
endpoint from regionProvider
- auth/sso OidcClient.authorize: derive dnsSuffix for the OIDC endpoint
Added GovCloud (aws-us-gov) test cases for both ARN parsers.
Note: two hardcoded endpoints were intentionally left for follow-up as
they need endpoint-format confirmation, not a mechanical fix:
- datazoneCustomClientHelper `datazone.{region}.api.aws`
- smusUtils Identity Center issuer `identitycenter.amazonaws.com`
(coupled to a validation regex in auth/sso/constants.ts)
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local IDE hardcoded the commercial
awspartition and.amazonaws.comDNS suffix in several ARN and endpoint constructions, which break in GovCloud (aws-us-gov partition). Route these through the existing regionProvider (getPartitionId / getDnsSuffixForRegion) so they resolve correctly per partition.Added GovCloud (aws-us-gov) test cases for both ARN parsers.
Note: two hardcoded endpoints were intentionally left for follow-up as they need endpoint-format confirmation, not a mechanical fix:
datazone.{region}.api.awsidentitycenter.amazonaws.com(coupled to a validation regex in auth/sso/constants.ts)Problem
Solution
feature/xbranches will not be squash-merged at release time.