fix(memory): remove Strands Bidi hooks - #666
Closed
Hweinstock wants to merge 2 commits into
Closed
Hweinstock wants to merge 2 commits into
Hweinstock wants to merge 2 commits into
Conversation
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Hweinstock
had a problem deploying
to
auto-approve
September 16, 2026 14:45 — with
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage ? 89.51%
=======================================
Files ? 123
Lines ? 10704
Branches ? 1677
=======================================
Hits ? 9582
Misses ? 734
Partials ? 388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec
Issue #665: #665
Problem
The Strands session manager imported experimental Bidi hook events that are not available in the current Strands API, breaking standard CLI-generated Strands projects during import.
Solution
Removed direct Bidi event imports and registrations, removed the obsolete Bidi unit test, and replaced inherited sync hook registration with equivalent standard Agent and multi-agent callbacks so no Bidi callback is registered while memory initialization, retrieval, persistence, batching, and synchronization remain unchanged.
Verification
181 passedwith Strands 1.56.0.us-east-1:12 passedin 524.16s.git diff --check: passed.Agent AgentCoreMemorySessionManager.Reproduce