Skip to content

fix(memory): remove Strands Bidi hooks - #666

Closed
Hweinstock wants to merge 2 commits into
aws:mainfrom
Hweinstock:fix/remove-bidi-strands-session-manager
Closed

Hweinstock wants to merge 2 commits into
aws:mainfrom
Hweinstock:fix/remove-bidi-strands-session-manager

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Spec

Issue #665: #665

Problem

The Strands session manager imported experimental Bidi hook events that are not available in the current Strands API, breaking standard CLI-generated Strands projects during import.

Solution

Removed direct Bidi event imports and registrations, removed the obsolete Bidi unit test, and replaced inherited sync hook registration with equivalent standard Agent and multi-agent callbacks so no Bidi callback is registered while memory initialization, retrieval, persistence, batching, and synchronization remain unchanged.

Verification

  • Unit suite: 181 passed with Strands 1.56.0.
  • Dev-account integration suite in us-east-1: 12 passed in 524.16s.
  • Ruff and git diff --check: passed.
  • Production scan: no Bidi event imports or registrations.
  • CLI-style import with Strands 1.56.0: Agent AgentCoreMemorySessionManager.

Reproduce

uv run --python 3.10 --with 'strands-agents==1.56.0' --extra strands-agents \
  pytest tests/bedrock_agentcore/memory/integrations/strands/test_agentcore_memory_session_manager.py -q

BEDROCK_TEST_REGION=us-east-1 uv run --python 3.10 \
  --with 'strands-agents==1.56.0' --extra strands-agents \
  pytest tests_integ/memory/integrations/test_session_manager.py -v

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9f31042). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage        ?   89.51%           
=======================================
  Files           ?      123           
  Lines           ?    10704           
  Branches        ?     1677           
=======================================
  Hits            ?     9582           
  Misses          ?      734           
  Partials        ?      388           
Flag Coverage Δ
unittests 89.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 16, 2026
@Hweinstock Hweinstock closed this Sep 16, 2026

This branch had an error being deployed

1 failed deployment
auto-approve — b8e026ad Deployed Sep 16, 2026 by Hweinstock via Test (identity) #1575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants