Skip to content

fix(integ): adjust timeout on memory test. - #667

Merged
Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:fix/memory-delete-timeout
Sep 16, 2026
Merged

Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:fix/memory-delete-timeout

Conversation

@Hweinstock

Copy link
Copy Markdown
Contributor

Problem

Tests are timing out on delete https://github.com/aws/bedrock-agentcore-sdk-python/actions/runs/35110378662/job/104856020087.

Also noticed a race condition where update does not wait for the memory to be active before continuing.

Solution

  • extend timeout to 300s.
  • add wait_for_active.

Verification

ran tests in dev account.

@Hweinstock
Hweinstock requested a review from a team September 16, 2026 15:46
@github-actions github-actions Bot added the size/xs PR size: XS label Sep 16, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 16, 2026
@Hweinstock Hweinstock changed the title Fix/memory delete timeout fix(integ): adjust timeout on memory test. Sep 16, 2026
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Sep 16, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 16, 2026
@Hweinstock

Copy link
Copy Markdown
Contributor Author

Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

integ test failures unrelated, doesn't allow run from fork, but ran memory in dev account.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@cc980d1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage        ?   89.52%           
=======================================
  Files           ?      123           
  Lines           ?    10705           
  Branches        ?     1678           
=======================================
  Hits            ?     9584           
  Misses          ?      733           
  Partials        ?      388           
Flag Coverage Δ
unittests 89.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hweinstock
Hweinstock merged commit 2715d6f into aws:main Sep 16, 2026
30 of 40 checks passed

This branch had an error being deployed

1 failed deployment
auto-approve — a074a625 Deployed Sep 16, 2026 by Hweinstock via Test (gateway) #1577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants