Skip to content

feat(payments): attribute SDK usage via user-agent integration source - #669

Merged
aidandaly24 merged 1 commit into
aws:mainfrom
rajuans:feat/payments-surface-instrumentation
Sep 21, 2026
Merged

feat(payments): attribute SDK usage via user-agent integration source#669
aidandaly24 merged 1 commit into
aws:mainfrom
rajuans:feat/payments-surface-instrumentation

Conversation

@rajuans

@rajuans rajuans commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Propagate an origin signal through the boto3 User-Agent so the payments data plane can measure who is calling.

  • build_user_agent_suffix gains an optional feature token → bedrock-agentcore/X.Y.Z (integration_source=strands; feature=payments).
  • PaymentManager (data plane) and PaymentClient (control plane) now take integration_source (default raw-sdk) and emit it with feature=payments.
  • Strands plugin sets integration_source="strands"; LangGraph middleware sets "langgraph".
  • Lets the payments data plane count callers by surface / version / operation from each request. No new data leaves the caller.

Tests

  • New tests/bedrock_agentcore/_utils/test_user_agent.py — user-agent formatting, feature token, sanitization.
  • Updated Strands/LangGraph init assertions for the new integration_source kwarg.
  • Full payments suite green (906 passed, 9 testnet-only skipped); ruff lint + format clean.

@rajuans
rajuans requested a review from a team September 17, 2026 18:21
@rajuans rajuans mentioned this pull request Sep 17, 2026
Closed
@github-actions github-actions Bot added the size/m PR size: M label Sep 17, 2026
@codecov-commenter

codecov-commenter commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@aea2005). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage        ?   89.53%           
=======================================
  Files           ?      123           
  Lines           ?    10712           
  Branches        ?     1680           
=======================================
  Hits            ?     9591           
  Misses          ?      733           
  Partials        ?      388
Flag Coverage Δ
unittests 89.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 17, 2026
@agentcore-devx-automation

agentcore-devx-automation Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 17, 2026
Raju Ansari
feat(payments): attribute SDK usage via user-agent integration source
003dbcd 
Propagate an integration_source through the boto3 User-Agent so the payments
data plane can count callers by surface / version / operation from each request.

- build_user_agent_suffix gains an optional feature token, e.g.
  bedrock-agentcore/X.Y.Z (integration_source=strands; feature=payments).
- PaymentManager (data plane) and PaymentClient (control plane) accept
  integration_source (default "raw-sdk") and emit it with feature=payments.
- Strands plugin sets integration_source="strands"; LangGraph middleware sets
  "langgraph".

No new data leaves the caller. Adds unit coverage for the user-agent formatting.
@rajuans rajuans changed the title feat(payments): attribute SDK usage via user-agent surface tag and created-by resource tag feat(payments): attribute SDK usage via user-agent integration source Sep 18, 2026
@rajuans
rajuans force-pushed the feat/payments-surface-instrumentation branch from 57dc939 to 003dbcd Compare September 18, 2026 22:20
@github-actions github-actions Bot added size/s PR size: S and removed size/m PR size: M labels Sep 18, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Sep 18, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 18, 2026
@agentcore-devx-automation

agentcore-devx-automation Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 18, 2026
@aidandaly24

aidandaly24 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Confirmed integ tests pass

aidandaly24
aidandaly24 reviewed Sep 21, 2026
View reviewed changes

@aidandaly24 aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding

@aidandaly24
aidandaly24 merged commit 889615f into aws:main Sep 21, 2026
31 of 41 checks passed

This branch had an error being deployed

1 failed deployment
auto-approve — 003dbcd5 Deployed Sep 18, 2026 by rajuans via Test (tools) #1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidandaly24 aidandaly24 aidandaly24 approved these changes

Assignees

No one assigned

Labels

size/s PR size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rajuans @codecov-commenter @aidandaly24