Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
- Stop ragas' background telemetry thread in tests. It calls time.sleep(1) in a loop, and patching time.sleep in a test patches it for every thread, so the mock picked up hundreds of stray calls. - Skip test_third_party_adapters.py in the compat job. It needs OpenAI and Braintrust API keys that the job doesn't have.
jariy17
force-pushed
the
fix/ci-sleep-mock-isolation
branch
from
September 23, 2026 18:49
94188e6 to
a7a7925
Compare
jariy17
marked this pull request as ready for review
September 23, 2026 18:55
nborges-aws
approved these changes
Sep 23, 2026
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures seen on #674 and #675. Neither was caused by those PRs.
1. Flaky
test_zero_delay_skips_sleepFails with
Expected 'sleep' to not have been called. Called 898 times.Why:
time.sleep(1)in a loop.RAGAS_DO_NOT_TRACKdoesn't stop it.middleware.time.sleep. That patches the sharedtimemodule, so every thread sees the mock.Fix:
tests/conftest.pystops the ragas thread after the first test that imports ragas.2.
Compat (evaluation)errorstest_third_party_adapters.pyneeds OpenAI and Braintrust API keys. The compat job doesn't have them, so its 16 tests always error. This PR skips them in that job; the secure integ workflow still runs them.Follow-up: add skip guards to the test file itself so this ignore can be removed.
Testing