Skip to content

Move snapshot test device to iPhone 18 Pro Max #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradleymackey merged 1 commit into from
Sep 13, 2026
Merged

Move snapshot test device to iPhone 18 Pro Max #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/validate-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
-workspace Vault.xcworkspace \
-scheme CI_iOS \
-testPlan iOSAllTests \
-destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=27.0' \
-destination 'platform=iOS Simulator,name=iPhone 18 Pro Max,OS=27.0' \
-derivedDataPath "$RUNNER_TEMP/ci-ios-derived-data" \
-skipMacroValidation \
-skipPackagePluginValidation
Expand Down Expand Up @@ -180,7 +180,7 @@ jobs:

xcodebuild test-without-building \
-xctestrun "$XCTESTRUN" \
-destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=27.0' \
-destination 'platform=iOS Simulator,name=iPhone 18 Pro Max,OS=27.0' \
-only-testing:${{ matrix.only_testing }} \
-parallel-testing-enabled NO

Expand Down
2 changes: 1 addition & 1 deletion Vault/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Designed to cause an internal error during key generation.
<table>
<tr>
<td>Simulator for snapshot tests</td>
<td><b>iPhone 17 Pro on iOS 27.0</b></td>
<td><b>iPhone 18 Pro Max on iOS 27.0</b></td>
</tr>
</table>

Expand Down
2 changes: 1 addition & 1 deletion Vault/Sources/TestHelpers/SnapshotTesting/AssertSnapshotWithDeviceCheck.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import UIKit

/// Expected device configuration for snapshot tests.
/// This must match the configuration specified in Vault/README.md.
private let expectedDeviceName = "iPhone 17 Pro"
private let expectedDeviceName = "iPhone 18 Pro Max"
private let expectedIOSVersion = "27.0"
private let expectedLocaleIdentifier = "en_US"
private let expectedTimezoneIdentifier = ["UTC", "GMT"]
Expand Down