Point the in-app source code link at the renamed repository - #552
Merged
Merged
Conversation
The repository moved from badbundle/vault-ios to badbundle/vault-app. The "View the source code on GitHub" link in Settings still pointed at the old name, which only worked because GitHub redirects renamed repositories. This was the only reference to the old name outside local tool configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the in-app source code link at the renamed repository.
The repo moved from
badbundle/vault-iostobadbundle/vault-app, but the View the source code on GitHub link in Settings still pointed at the old name. It worked only because GitHub redirects renamed repositories — a redirect that stops working if the old name is ever claimed by another repo.Scope
This was the only reference to the old name anywhere in the tree. The remaining
vault-iosstrings are all inVault/.claude/settings.local.json, and those are local filesystem paths — the working directory is still literally namedvault-ioson disk — not the repository URL, so they are correct as-is and untouched.No visible change
The link's label is the localized string
openSource.aboutLink("View the source code on GitHub"), not the URL itself, so nothing rendered changes. Confirmed by the snapshot suite: zero reference images changed.Verification
Local, Xcode 27.0 RC1 (
27A266a), iPhone 18 Pro Max / iOS 27.0:xcodebuild build-for-testing—TEST BUILD SUCCEEDED, no warnings-parallel-testing-enabled NO—TEST EXECUTE SUCCEEDED, 2852 passed, 0 failures, both configurationsgit statusreports no change under any__Snapshots__directorymake format+make lint— clean🤖 Generated with Claude Code