Unobfuscate TOTP previews when the scene becomes active - #563
Merged
Merged
Conversation
TOTP previews obfuscate on background/inactive but had no unobfuscate path — unobfuscateForPrivacy() existed only for HOTP — so a transient inactive (Control Centre, system alert) left codes hidden until the next timer emission. Mirror the HOTP repository/generator semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TOTP preview codes are obfuscated when the scene leaves
.active(privacy cover for the app switcher), but the.activecase only restarted timers — there was no unobfuscate path at all for TOTP (unobfuscateForPrivacy()existed only on the HOTP repository). A transient.inactive(Control Centre, system alert, app switcher peek) left every TOTP code showing as obfuscated until the next timer emission.Fix
Mirror the HOTP semantics exactly:
TOTPPreviewViewRepositorygainsunobfuscateForPrivacy()(protocol + impl), iterating the cached view models withupdateRemovePrivacyObfuscation()— same shape asHOTPPreviewViewRepositoryImpl.TOTPPreviewViewGenerator.scenePhaseDidChange(.active)now unobfuscates before restarting timers, so codes reappear immediately instead of waiting for the next tick.The privacy direction (obfuscate on
.background/.inactive) is untouched.Tests
.activecalls unobfuscate + restart (renamed test, mirrors the HOTP generator suite);.background/.inactiveassert unobfuscate is never called.unobfuscateForPrivacy_unobfuscatesCodesHiddenForPrivacy— visible code → privacy-obfuscated → restored (mirrors the HOTP repository test).Local verification: VaultFeedTests + VaultiOSTests schemes, all passed on iPhone 18 Pro Max / iOS 27.0.
🤖 Generated with Claude Code