Declare the drag-identifier UTType correctly across bundles - #566
Merged
Merged
Conversation
UTType(exportedAs:) faults when the calling bundle does not declare the type, and the autofill extension links VaultiOS (its code selector embeds the feed drag rows) with no declaration at all. Switch the shared code to importedAs, repair the malformed export in the main app Info.plist, and add the import declaration to the extension. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UTType(exportedAs: "vault.identifier.drop.id")inVaultItem+Transferable.swiftis evaluated in every bundle that linksVaultiOS— including the autofill extension, whose code selector embedsVaultItemFeedViewand therefore registers the.draggable/.dropDestinationtransfer types.exportedAson an identifier the calling bundle does not declare is a programming error at runtime (fault log, undefined type resolution), and:VaultAppAutofill/Info.plistdeclared nothing at all;UTExportedTypeDeclarationsentry was malformed —UTTypeConformsTocontaining a single empty string and an emptyUTTypeTagSpecificationdict.Fix
UTType(importedAs: "vault.identifier.drop.id", conformingTo: .data)— correct for shared code evaluated in multiple bundles; never faults on an undeclared identifier. The identifier itself is unchanged, so drag payloads are unaffected.public.data, added a description, dropped the empty tag-specification dict.UTImportedTypeDeclarationsentry.Verification
plutil -lintpasses on both plists.VaultAppscheme (app + both extensions) builds for the simulator.🤖 Generated with Claude Code