Put the feed bar on Liquid Glass and collapse it in landscape

[bradleymackey]

Summary

The bottom feed bar (item count / active filter / Clear + Edit) sat on a 5% primary fill, so the grid bled straight through and it read as nearly transparent; the tag pills had no backing at all. The two rows also ran ~117pt tall, which eats a big slice of an iPhone in landscape.

• Liquid Glass: the status bar and each tag pill now render on .regular glass. A system-background wash (Color(.systemBackground).opacity(0.85)) sits behind the glass so tile text underneath stays blurred out in both light and dark mode.
  • This is a backdrop rather than Glass.tint — a tinted glass renders as a fully empty image under CALayer.render(in:), which blanked every snapshot test that includes the feed.
  • The pills' GlassEffectContainer lives inside the horizontal scroll view: glass renders at the container's level, so a container outside the scroll view let pills draw past its clip and over the bar in the landscape row.
• Compact everywhere: dropped the 44pt min-height and tightened paddings. TagPillView takes smaller insets when controlSize is .small/.mini, so the detail-view pills (and their snapshots) are untouched. Portrait is ~85pt now (was ~117pt).
• Single row in landscape: when verticalSizeClass == .compact the tag row and the bar share one ~40pt row — pills scroll on the leading side, the bar hugs trailing. With no tags the bar still sits trailing.
• Constant bar height: the buttons size the row, so a hidden zero-width Edit button always sits behind the cluster — the bar is the same height whether the feed is empty, filtered to nothing, or populated. Clear now follows the filter (not the results), so a filter that matches nothing can still be cleared from the bar; Edit still needs items.
• Short filter-change animation in the bar: the default .snappy spring on itemsFilteringByTags faded the filter name / Clear button out over ~430ms while the glass capsule morphed, which read as the bar lagging the tap. A .snappy(duration: 0.2) spring keeps the morph but the text settles ~200ms after the pill (measured from 60fps simulator recordings of the old, none, and new variants).
• Pill insets: the pill stroke straddles the capsule edge, and both the glass container and (in the landscape row) the scroll view clip at their bounds — so the pills carry a 2pt vertical inset inside the container and a 2pt horizontal inset in the landscape row. Portrait row spacing is 8pt (10pt visible gap to the bar).
• Tests: framedForLandscapeTest() helper (and framedForTest now pins the regular vertical size class — UIKit reports compact for short frames); landscape snapshots; height pairs with/without Edit in both layouts on a grey backdrop so the bar surface is visible; a zero-result-filter case keeping Clear; a landscape overflow case clipping before the bar. Feed, main-navigation and autofill snapshots re-recorded. Glass itself doesn't render in the layer.render-based snapshots, so they verify layout — the look was checked in the Xcode preview (light/dark/landscape).
• Preview: the feed preview now has tags and coloured tiles so the glass can be eyeballed over real content.

Verification

• make format / make lint clean.
• VaultItemFeedViewSnapshotTests, VaultMainNavigationViewSnapshotTests, TagPillViewSnapshotTests, OTPCodeDetailViewSnapshotTests, SecureNoteDetailViewSnapshotTests, VaultAutofillCodeSelectorViewSnapshotTests pass on iPhone 18 Pro Max / iOS 27.0 (recorded, then re-run to confirm stable).
• Rendered the VaultItemFeedView preview in portrait, landscape and dark mode.
• Recorded the simulator while toggling a tag pill on the old and new bar and measured the label's change frame relative to the pill's.

🤖 Generated with Claude Code