Validate --stem is non-empty in steer-report - #23
Merged
Conversation
An empty or whitespace-only --stem silently produced dotfiles named
".md", ".html", ".png" instead of erroring. The other output paths
validate their inputs; --stem did not.
Fail fast with parser.error("output stem must not be empty") right after
parsing, before any rendering. Add a parametrized test covering empty and
whitespace-only stems.
Closes bamdadd#18
dchaudhari7177
added a commit
to dchaudhari7177/steerbench
that referenced
this pull request
Aug 14, 2026
An invalid --effect-col reached the user as an uncaught ValueError from mid-parse in report.py, exiting 1 with a traceback. The message content was right, but the delivery was inconsistent with every other CLI input error -- the missing-CSV guards a few lines above, and bamdadd#21/bamdadd#22/bamdadd#23, all go through parser.error() for a clean one-line message and exit 2. Pre-validate the column against both sweep headers instead, next to the existing existence checks. report.sweep_columns() splits the header read out of _read_sweep_rows so the check does not duplicate the parse; the in-parse guard stays as the library-level backstop for direct load_dose_curve callers. Checking both CSVs matters because the column is read from each: a name only one sweep carries now names which file is short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
steer-report --stem ""silently produced dotfiles named.md,.html,.pnginstead of erroring. The other output paths validate their inputs;--stemdid not.Change: an empty or whitespace-only
--stemnow fails fast withparser.error("output stem must not be empty"), added right after parsing (before any rendering). No other logic changes.Acceptance criteria:
steer-report --stem ""(and whitespace-only) exits non-zero with a clear stderr message. ✅tests/test_cli.py— parametrized over""and" ", assertingSystemExitwith a non-zero code and the message. ✅ruff check/formatclean.