CI: run rspec and rubocop on every pull request - #106
Merged
Merged
Conversation
The repo only had the manual release workflow, so the suite ran wherever someone remembered to run it. Ruby 3.4, matching connected_health and Global Admin. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The repo only had the manual "Publish Gem" workflow, so the spec suite ran wherever someone remembered to run it. kb-ruby#105 was verified in a local Docker container and nowhere else. Every pull request should run the suite.
Changes
.github/workflows/ci.yml: two jobs on every pull request and on pushes to master, both on Ruby 3.4 (what connected_health and Global Admin run):bundle exec rubocop lib specandbundle exec rspec. Bundler cache viaruby/setup-ruby.No matrix on purpose; one Ruby keeps it fast and the gem's
required_ruby_versionalready documents the supported range.Checklist
lib/kb/version.rbupdated (not applicable)How to test
This PR's own checks: the CI workflow runs against this branch and must be green. Then rebase #105 onto it to see the suite run there too.
🤖 Generated with Claude Code