Update playwright-ruby-client requirement from ~> 1.59.0 to >= 1.59, < 1.63 - #119
Update playwright-ruby-client requirement from ~> 1.59.0 to >= 1.59, < 1.63#119dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the Playwright Ruby client dependency constraints to allow newer compatible versions and refreshes the lockfile accordingly.
Changes:
- Relax
playwright-ruby-clientdependency from~> 1.59.0to a bounded range (>= 1.59,< 1.63). - Update
Gemfile.lockto resolve Playwright to1.62.0. - Lockfile includes additional indirect dependency bumps (e.g.,
concurrent-ruby,mime-types-data).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| upright.gemspec | Broadens the allowed Playwright client versions with an upper bound. |
| Gemfile.lock | Resolves Playwright to 1.62.0 and updates some transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -38,7 +38,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| # Playwright (browser automation) | |||
| # Keep in sync with Upright::PLAYWRIGHT_VERSION in lib/upright/version.rb | |||
41d7a10 to
ebcafb9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
upright.gemspec:40
- The comment says to keep this dependency “in sync” with
Upright::PLAYWRIGHT_VERSION, but the dependency is now a version range rather than a single version. This makes “in sync” ambiguous/misleading. Consider either (a) updating the comment to specify what should match (e.g., minimum supported Playwright version), or (b) expressing the constraint in terms of the constant (so there is a single source of truth).
# Keep in sync with Upright::PLAYWRIGHT_VERSION in lib/upright/version.rb
spec.add_dependency "playwright-ruby-client", ">= 1.59", "< 1.63"
ebcafb9 to
5f32f91
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
upright.gemspec:40
- The comment says to keep this in sync with
Upright::PLAYWRIGHT_VERSION(which implies a single version), but the gemspec now allows a version range. To avoid confusion/mismatches, either (a) update the comment to describe the supported range and where that range is defined, or (b) change the code to reference range-specific constants (e.g., min/max) instead of a singlePLAYWRIGHT_VERSION.
# Playwright (browser automation)
# Keep in sync with Upright::PLAYWRIGHT_VERSION in lib/upright/version.rb
spec.add_dependency "playwright-ruby-client", ">= 1.59", "< 1.63"
5f32f91 to
9415bec
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
upright.gemspec:45
- The comment says to keep this dependency “in sync with Upright::PLAYWRIGHT_VERSION”, but the dependency is now a range (>= 1.59, < 1.63). This makes it unclear what “in sync” means (min supported version, currently tested version, or max allowed). Update the comment (or the referenced constant’s meaning) to explicitly state which version the constant represents and how it relates to the allowed range.
# Playwright (browser automation)
# Keep in sync with Upright::PLAYWRIGHT_VERSION in lib/upright/version.rb
spec.add_dependency "playwright-ruby-client", ">= 1.59", "< 1.63"
…< 1.63 Updates the requirements on [playwright-ruby-client](https://github.com/YusukeIwaki/playwright-ruby-client) to permit the latest version. - [Commits](YusukeIwaki/playwright-ruby-client@1.59.0...1.62.0) --- updated-dependencies: - dependency-name: playwright-ruby-client dependency-version: 1.62.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9415bec to
94ad984
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
upright.gemspec:45
- The comment says to keep this dependency in sync with
Upright::PLAYWRIGHT_VERSION, but the dependency is now a version range (not a single version). This is misleading and can cause future updates to incorrectly ‘sync’ to a single value. Update the comment (or the referenced constant’s meaning) to reflect that Upright supports a bounded range (e.g., keep the min/max bounds in sync), not one exact version.
# Keep in sync with Upright::PLAYWRIGHT_VERSION in lib/upright/version.rb
spec.add_dependency "playwright-ruby-client", ">= 1.59", "< 1.63"
Updates the requirements on playwright-ruby-client to permit the latest version.
Commits
dcbfb57Bump PLAYWRIGHT_CORE_VERSION in Alpine guide to 1.62.19799fa3Merge pull request #391 from YusukeIwaki/driver/1.62.07ef574bUpdate Playwright client for 1.62cf28795Merge pull request #390 from YusukeIwaki/reassemble_driver8f0277fUse playwright-core instead of standalone driver5953a99Merge pull request #388 from YusukeIwaki/codex/improve-documentation-discover...0e80cf3Improve documentation discoverability1ade61dMerge pull request #386 from YusukeIwaki/codex/document-capybara-selenium-inc...dc9cac8Document Capybara Selenium migration incompatibilities0a0b740Merge pull request #384 from YusukeIwaki/codex/playwright-1.61.1-follow-up