Add dndscv plots and expanded needle plots - #491
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the DeepCSA pipeline’s positive-selection visualization and reporting by adding per-sample dNdScv outputs to the aggregated results and incorporating a new dNdScv track in the side-plot summaries, alongside generating an “expanded” variant of the needle plots.
Changes:
- Join per-sample dNdScv CV results into the workflow-level
positive_selection_resultschannel and expose them from the DNDS subworkflow. - Add a dNdScv track to the positive-selection side plot generation and load per-sample dNdScv CV metrics for plotting.
- Add expanded needle plot generation and update needle plotting to use explicit start/end positions.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Adds per-sample dNdScv CV results into the aggregated positive selection results stream. |
| subworkflows/local/dnds/main.nf | Exposes DNDS CV per-sample results as an emitted channel for downstream joins/plotting. |
| bin/utils_plot.py | Adds a color mapping for the truncating label used by new plots. |
| bin/plot_selectionsideplots.py | Adds dNdScv as an optional plotting track and loads per-sample dNdScv CV data for the summary plot. |
| bin/plot_needles.py | Adds “expanded” needle plots and switches plotting to use explicit start/end position ranges. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.