Repository navigation
feat(chart): render spec.tokenCeiling from agent values (chart 0.23.21) - #197
Merged
Merged
Conversation
Adds tokenCeiling to the Config render and the CRD schema, so a per-agent token ceiling set in a values file reaches the Config. Declared in the CRD because it sets preserveUnknownFields: false and would otherwise prune the key.
bborbe
marked this pull request as ready for review
November 15, 2026 12:20
Contributor
There was a problem hiding this comment.
Chart-only change: tokenCeiling is rendered into the Config template and declared in the CRD schema, mirroring the accepted runWindow/runBudgetSeconds precedent (commit 9e25edc); rendering semantics (unset or 0 omitted) match the CRD's declared contract and a non-integer value fails closed at admission. Reviewed d12ea81 against master (3 files, 0 excluded by .reviewignore; deterministic funnel ran 79 YAMLs with 0 findings, judgment tier skipped — no rule-relevant files changed, precommit skipped in selector mode — CI covers lint+test); the only real gap is that the new values key and its minimum paired executor version are undocumented, which is non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: 8c45c38f-abf5-43f2-9f05-00c1ea1d57ca
Renders
tokenCeilingfrom an agent's values into the Config spec, and declares it in the CRD schema (which setspreserveUnknownFields: false, so an undeclared field is pruned). Completes the helm half of the token-budget task — without it atokenCeilingset invalues-dev.yamlnever reaches the Config.Pairs with
bborbe/agent-task-executor#246(the admission check that enforces it). Chart 0.23.20 → 0.23.21.