Skip to content

feat(chart): render spec.tokenCeiling from agent values (chart 0.23.21) - #197

Merged
bborbe merged 2 commits into
masterfrom
feat/token-ceiling-helm
Nov 15, 2026
Merged

bborbe merged 2 commits into
masterfrom
feat/token-ceiling-helm

Conversation

@bborbe

@bborbe bborbe commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Task: 8c45c38f-abf5-43f2-9f05-00c1ea1d57ca

Renders tokenCeiling from an agent's values into the Config spec, and declares it in the CRD schema (which sets preserveUnknownFields: false, so an undeclared field is pruned). Completes the helm half of the token-budget task — without it a tokenCeiling set in values-dev.yaml never reaches the Config.

Pairs with bborbe/agent-task-executor#246 (the admission check that enforces it). Chart 0.23.20 → 0.23.21.

Adds tokenCeiling to the Config render and the CRD schema, so a per-agent
token ceiling set in a values file reaches the Config. Declared in the CRD
because it sets preserveUnknownFields: false and would otherwise prune the key.
@bborbe
bborbe marked this pull request as ready for review November 15, 2026 12:20

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart-only change: tokenCeiling is rendered into the Config template and declared in the CRD schema, mirroring the accepted runWindow/runBudgetSeconds precedent (commit 9e25edc); rendering semantics (unset or 0 omitted) match the CRD's declared contract and a non-integer value fails closed at admission. Reviewed d12ea81 against master (3 files, 0 excluded by .reviewignore; deterministic funnel ran 79 YAMLs with 0 findings, judgment tier skipped — no rule-relevant files changed, precommit skipped in selector mode — CI covers lint+test); the only real gap is that the new values key and its minimum paired executor version are undocumented, which is non-blocking.

@bborbe
bborbe merged commit b4adeb0 into master Nov 15, 2026
8 checks passed
@bborbe
bborbe deleted the feat/token-ceiling-helm branch November 15, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant