Skip to content

feat(chart): expose keel policy as keel.policy value defaulting to all - #198

Merged
bborbe merged 2 commits into
masterfrom
feat/keel-policy
Nov 16, 2026
Merged

bborbe merged 2 commits into
masterfrom
feat/keel-policy

Conversation

@bborbe

@bborbe bborbe commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Exposes the keel policy as keel.policy, defaulting to all.

keel.sh/policy: force was hardcoded in all four annotation blocks across three templates, and only keel.enabled / keel.pollSchedule were values — so the policy could not be set from a values file, and an edit made on the live object was rewritten by the next apply.

Changes

  • helm/values.yaml: new keel.policy: all
  • all four literal sites now render {{ .Values.keel.policy }} ($.Values inside the executors: range)
  • helm/README.md: keel.policy row
  • CHANGELOG.md: ## Unreleased bullet

Verification

Rendered with -f nuke-prod/agent/values-prod.yaml --set executor.existingSecret=probe-dummy:

  • grep -c 'keel.sh/policy: all' → 7
  • grep -c 'keel.sh/policy: force' → 0
  • grep -rn 'keel.sh/policy: force' helm/templates/ → no matches
  • helm lint helm → 1 chart linted, 0 failed

Notes

Behaviour change: a keel.enabled: true render now emits policy: all rather than force. keel.sh/match-tag stays a literal and is not converted here. The value is rendered unquoted, matching the sibling keel.sh/trigger: poll.

Task: 5b18b06e-918c-4cdf-a45b-4a60323c2d4c

@bborbe
bborbe marked this pull request as ready for review November 15, 2026 23:43

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, well-documented chart change that exposes the keel policy as keel.policy (default all) at all four annotation sites; both executor blocks and the $ scoping inside the ranges are right, and the behaviour change is called out in the CHANGELOG and README. Only non-blocking hardening remains: fail-fast enum validation, a keel-enabled render test, quoting the annotation value, and documenting the hardcoded match-tag interaction. (Judgment tier: selector ran, 0 rule violations; intent unavailable — no PR body/network in this sandbox.)

@bborbe
bborbe merged commit ccaa96e into master Nov 16, 2026
8 checks passed
@bborbe
bborbe deleted the feat/keel-policy branch November 16, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant