Skip to content

feat: require a Task identifier line in the PR body - #103

Merged
bborbe merged 1 commit into
masterfrom
feat/pr-task-link-check
Nov 14, 2026
Merged

bborbe merged 1 commit into
masterfrom
feat/pr-task-link-check

Conversation

@bborbe

@bborbe bborbe commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Adds a check-task-link workflow that fails a PR whose body carries no Task: <task_identifier> line.

The identifier must be a UUID, not a title. A title does not survive a rename, and the vault resolves identifiers rather than names.

Also fixes this repo's test check, red on every PR since 2026-11-14: the Trivy install used the retired apt keyring helper. Replaced with a pinned v0.76.2 release verified by sha256.

Wiring: the workflow alone is advisory until task-link is added to the ruleset's required checks — a separate, operator-gated step.

Task: 7c73a03d-8e9e-48e3-b6cf-556e788c7a8b

@bborbe
bborbe marked this pull request as ready for review November 14, 2026 15:02

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changed workflows are sound: the new check-task-link gate consumes the attacker-controlled PR body through a quoted PR_BODY env var (no inline interpolation), runs on pull_request with contents: read and no third-party actions, and the ci.yml Trivy install is version-pinned and checksum-verified before extraction, failing closed on mismatch. Deterministic tier ran (0 findings), judgment tier selector ran (no violations; one non-blocking nit), security tier skipped (--security not requested), precommit skipped (selector mode — CI covers lint+test); operational note: the ruleset required-check context will be the job id task-link, not the workflow name check-task-link, per the repo's sibling-workflow convention.

@bborbe
bborbe merged commit a5055b4 into master Nov 14, 2026
8 checks passed
@bborbe
bborbe deleted the feat/pr-task-link-check branch November 14, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant