Repository navigation
chore: remove Claude Code review and mention workflows - #95
Merged
Merged
Conversation
Both workflows call anthropics/claude-code-action, which is not installed as a GitHub App on this repository, so every run fails. PR review is owned by the pr-reviewer agent fleet.
Contributor
There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "Single-file deletion of the label-triggered Claude Code Review workflow; it removes a floating third-party action, an OIDC token grant, and PR/issue read scopes with no remaining live references to the workflow, its label, or its secret. Branch protection is unaffected (master requires the `test` check from ci.yml, and a `labeled`-only workflow could never be a required check); precommit skipped (selector mode) — CI covers lint+test. Step 4 skipped: no rule-relevant files changed.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness: deleting the workflow could leave a required status check permanently Expected and block all merges",
"disposition": "not-an-issue",
"detail": "ci.yml on master states 'Branch protection on master requires a check named \"test\"'. Independently, the deleted workflow triggered only on `pull_request: types: [labeled]`, so it reported no status on ordinary PRs and could not have been a required check without already blocking every PR."
},
{
"concern": "correctness: PR claims three files removed but only one is in the diff; other two may be left behind",
"disposition": "not-an-issue",
"detail": "`git log --all -- .github/workflows/claude.yml .github/workflows/claude-review.yml` returns nothing — those paths never existed in any ref. Commit 13fbcc6 added only claude-code-review.yml; .github/workflows/ now contains check-do-not-merge.yml, check-unfinished-pipeline.yml, ci.yml. Grep for claude-review / claude-code-review / claude-code-action finds only a historical mention in specs/completed/001-mvp-review-single-pr.md."
},
{
"concern": "security: CLAUDE_CODE_OAUTH_TOKEN becomes unused; no credential should be echoed",
"disposition": "not-an-issue",
"detail": "No reference to CLAUDE_CODE_OAUTH_TOKEN remains anywhere in the worktree outside a completed spec. The diff only deletes a `with:` binding that reads the secret; nothing prints or echoes it. The change is a net reduction in CI attack surface (drops id-token: write, pull-requests/issues read, anthropics/claude-code-action@v1, and the remote plugin marketplace fetch). Retiring the repository secret is an operational follow-up, not a code defect."
},
{
"concern": "correctness: the claude-review label becomes a no-op; stale docs may still instruct contributors to use it",
"disposition": "not-an-issue",
"detail": "Grep for `claude-review`, `Claude Code Review`, and `plugin_marketplaces` finds no live documentation, README, or workflow reference — only completed specs describing past alternatives. No stale contributor instructions remain."
},
{
"concern": "tests: YAML-only deletion needs no new tests; verify the no-CHANGELOG claim matches repo practice",
"disposition": "not-an-issue",
"detail": "The CI `test` job in ci.yml is untouched and is the branch-protection required check. Prior CI-only workflow commits (870f253, 545eed6, 67de0d3) each touched only .github/workflows/* and added no CHANGELOG entry, so omitting one here matches repo practice."
}
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Claude Code ReviewandClaude Codeworkflows callanthropics/claude-code-action, which is not installed as a GitHub App on this repository, so every run fails withClaude Code is not installed on this repository. Please install the Claude Code GitHub App. PR review is owned by the pr-reviewer agent fleet, so these workflows only add a red check.Removes, where present:
.github/workflows/claude-code-review.yml.github/workflows/claude.yml.github/workflows/claude-review.ymlNo CHANGELOG entry: this is CI configuration, and adding one would mint a release.