Repository navigation
fix: scope ORPHAN_GOAL detection to the goals: block - #384
Conversation
There was a problem hiding this comment.
The scoping fix is correct and well-targeted: both goals regexes are now line-bounded, the multiline capture stops at the next top-level key, and the four new contexts pin the reported regression (no false ORPHAN_GOAL from themes/metrics_sessions, a genuine orphan still caught, doubled-apostrophe goal names resolved). No blocking defect found — the remaining items are a silent false-negative when a blank line or comment separates goals: from its list, a flow-list regression test that passes only because of a pre-existing lazy-] truncation, and two nits; judgment tier ran in selector mode (54 candidates, 11 applicable), the deterministic funnel ran (its single mechanical finding was dropped as a stdlib false positive per that rule's own enforcement note), precommit skipped (CI covers lint+test), 1 file excluded by .reviewignore, intent unavailable (gh not permitted).
Summary
vault-cli task lintreported thousands of falseORPHAN_GOALfindings (4662 lines / 1450 distinct values on private-personal).goalsMultilineRegexused(?ms), so.matched newlines and its greedy.+swallowed every frontmatter key aftergoals:; the per-line parser then reported list items fromthemes:/metrics_sessions:(and prose/paths) as missing goals.Changes
pkg/ops/lint.go: bound bothgoals:regexes to the block — no dotall flag,[ \t]instead of\s,[^\n]*instead of.+. Stops at the next top-level key.pkg/ops/lint.go:extractGoalNameunescapes YAML single-quote doubling (''->') so a goal whose filename contains an apostrophe resolves (132 such false rows on private-personal).pkg/ops/lint_test.go: four regression contexts — goals followed by themes/metrics_sessions (0 findings), genuine block-list orphan (1), flow-list orphan (1, theme excluded), escaped-apostrophe name (0).CHANGELOG.md:## Unreleasedbullet.Verification
make test/make precommitgreen in the dark-factory container (prompt 283).goals:entry still yields exactly 1ORPHAN_GOAL.Task: ad53acec-4ca2-45db-8243-e37f01f687e4