Skip to content

goal and topic complete use the same closure gate as task complete - #386

Open
bborbe wants to merge 9 commits into
masterfrom
fix/goal-topic-closure-gate
Open

bborbe wants to merge 9 commits into
masterfrom
fix/goal-topic-closure-gate

Conversation

@bborbe

@bborbe bborbe commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

What

Spec 069 — vault-cli goal complete and vault-cli topic complete must refuse to close a page whose own closure evidence is incomplete, through one shared check in pkg/ops ported from claude-supervisor/scripts/goal-closure-read.py.

Measured on the installed v0.196.0:

  • goal complete closes a goal with an open # Success Criteria box (exit 0, status: completed).
  • Its open-task guard never fires for a [[goal]]-style link, so an open linked task does not block either.
  • topic complete carries no gate at all — neither a # Completion Gate check nor a member-goal terminality check.

Status

Spec approved: specs/in-progress/069-bug-goal-topic-closure-gate.md.

Draft on purpose — the cluster dark-factory agent owns the implementation prompt for this spec. Do not flip to ready until the implementation lands.

Notes for review

  • One prompt, deliberately: a multi-row decomposition cannot be made to sort in dependency order by the generator (spec 067 hit this on 2026-11-16).
  • --force on goal complete keeps its narrow meaning: it bypasses the open-task gate only, never the closure gate.

Task: 30dc7d62-a831-4dd3-a429-75f8d178b290

@bborbe
bborbe marked this pull request as ready for review November 19, 2026 07:11
@bborbe bborbe changed the title WIP: goal and topic complete use the same closure gate as task complete goal and topic complete use the same closure gate as task complete Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant