Skip to content

fix: sign session op userOpHash for NoMee redemption - #214

Merged
fichiokaku merged 1 commit into
developfrom
fix/session-nomee-userophash
Sep 1, 2026
Merged

fichiokaku merged 1 commit into
developfrom
fix/session-nomee-userophash

Conversation

@fichiokaku

@fichiokaku fichiokaku commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Session quotes now personal-sign the session op's ERC-4337 userOpHash (already present in the quote) instead of the supertx hash. On-chain this routes to NoMeeFlowLib, which recovers over that userOpHash; signing the supertx hash recovered the wrong signer and failed with [0] Invalid signature.

Pairs with mee-node fix/session-nomee-passthrough. The 712 validator cannot be used with smart sessions (SmartSessions calls it externally, so hashTypedDataForAccount reads eip712Domain() on the SmartSessions singleton and reverts). Both changes are needed together. Validate with bcnmy/session-permissioned-intents PR #3 transfer.ts on staging.


PR-Codex overview

This PR updates the signature process for the NoMee flow in the signQuote.ts file. It modifies how the session key signs the user operation hash instead of the super transaction hash, ensuring compatibility with the new signature validation requirements.

Detailed summary

  • Removed comments about signing the quote hash and SuperTx wrapping.
  • Added comments clarifying the NoMee session flow and signature routing.
  • Introduced a check for the existence of a user operation with session details.
  • Updated the signature process to sign the userOpHash instead of the quote hash.
  • Modified the formatSignedQuotePayload call to pass an empty object for metadata.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Session quotes now personal-sign the session op's ERC-4337 userOpHash (the hash
SmartSessions forwards to K1MeeValidator) instead of the supertx hash. On-chain this
routes to NoMeeFlowLib, which recovers over that userOpHash; signing the supertx hash
recovered the wrong signer and failed with [0] Invalid signature.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

size-limit report 📦

Path Size
core (esm) 72.23 KB (-0.04% 🔽)
core (cjs) 87.37 KB (+0.06% 🔺)
bundler (tree-shaking) 7.2 KB (0%)
paymaster (tree-shaking) 543 B (0%)

@fichiokaku
fichiokaku merged commit f8f898a into develop Sep 1, 2026
4 of 5 checks passed
@fichiokaku
fichiokaku deleted the fix/session-nomee-userophash branch September 1, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant