Repository navigation
fix: sign session op userOpHash for NoMee redemption - #214
Merged
Merged
Conversation
Session quotes now personal-sign the session op's ERC-4337 userOpHash (the hash SmartSessions forwards to K1MeeValidator) instead of the supertx hash. On-chain this routes to NoMeeFlowLib, which recovers over that userOpHash; signing the supertx hash recovered the wrong signer and failed with [0] Invalid signature.
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session quotes now personal-sign the session op's ERC-4337
userOpHash(already present in the quote) instead of the supertx hash. On-chain this routes toNoMeeFlowLib, which recovers over that userOpHash; signing the supertx hash recovered the wrong signer and failed with[0] Invalid signature.Pairs with mee-node
fix/session-nomee-passthrough. The 712 validator cannot be used with smart sessions (SmartSessions calls it externally, sohashTypedDataForAccountreadseip712Domain()on the SmartSessions singleton and reverts). Both changes are needed together. Validate with bcnmy/session-permissioned-intents PR #3 transfer.ts on staging.PR-Codex overview
This PR updates the signature process for the NoMee flow in the
signQuote.tsfile. It modifies how the session key signs the user operation hash instead of the super transaction hash, ensuring compatibility with the new signature validation requirements.Detailed summary
userOpHashinstead of the quote hash.formatSignedQuotePayloadcall to pass an empty object for metadata.