Repository navigation
fix(formatter): preserve prefix quantities after semicolons - #2065
Draft
sebastian-griego wants to merge 1 commit into
Draft
sebastian-griego wants to merge 1 commit into
sebastian-griego wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter changes valid
(x = &0; &1)to(x = &0; & 1), which Bend rejects. A semicolon starts a new body, but the formatter did not include it inPREFIX_CONTEXT. Add the missing marker so the existing prefix rule preserves the quantity literal.Add six cases for
&0,&1, and&2, with adjacent and spaced semicolons and trailing comments. The existing test harness checks exact formatting, idempotence, and equal Bend output with default spaces, four spaces, and tabs.Validation:
npm test: TypeScript build and all 35 formatter/LSP tests pass; none skipped.let_dependent_type.bendandlet_unsafe_dependent_type.bend, check after formatting.bun gates/repo.ts: 56/56 pass.git diff --checkpasses.