chore: remove apache-arrow pnpm patch - #264
Merged
Merged
Conversation
pnpm patches are not applied when the installer is run with non-pnpm package managers (npm/yarn), leaving the workaround silently inactive. The underlying issue is fixed properly in the server code now, so the patch is no longer needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 55 55
Lines 1882 1882
Branches 518 518
=======================================
Hits 1579 1579
Misses 267 267
Partials 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Should follow #249 |
stordahl
marked this pull request as ready for review
September 7, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the pnpm
patchedDependenciesentry forapache-arrowalong withpatches/apache-arrow.patch.pnpm-specific patches are only applied when the installer is run with pnpm, so contributors using npm/yarn get the unpatched package silently. The underlying issue is now fixed properly in the server code, so the patch is unnecessary.
Changes
pnpm.patchedDependenciesfrompackage.jsonpatches/apache-arrow.patchpnpm-lock.yaml(lockfile no longer references the patch hash)Verification
pnpm install --frozen-lockfilesucceedspnpm --filter @counterscale/server buildpasses