Fix bounce-rate chart percentage scaling - #266
Open
benvinegar wants to merge 1 commit into
Open
benvinegar wants to merge 1 commit into
benvinegar wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 55 55
Lines 1882 1882
Branches 518 518
=======================================
Hits 1579 1579
Misses 267 267
Partials 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before and after
These Chromium captures use the actual
TimeSeriesChart, Recharts, and repository CSS. The capture waited for chart animation to complete and verified stable, complete SVG paths before taking each screenshot.For the 46% point:
The 100% point now reaches the top of the percentage plot, as expected. Full methodology, individual captures, geometry, checksums, and test output.
Validation
TimeSeriesChartregression test: 1 passedgit diff --check: passedFixes #128
This PR description was generated by Pi using OpenAI GPT-5.6 Sol