Take the bootstrap sweep off pull requests - #127
Closed
sscarduzio wants to merge 2 commits into
Closed
sscarduzio wants to merge 2 commits into
sscarduzio wants to merge 2 commits into
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
The matrix is 34 released versions x 2 envs, so it is 68 jobs. docs/dev/branching.md case 4 sends every workflow change to master. Three of them moved there today, and each queued its own 68 bootstrap jobs behind itself: approved, no failures, unmergeable for hours, while sweeping plugins that were released weeks ago. Every version in that matrix tests a plugin that is already out, so nothing a pull request changes can change the result. The nightly and a push to master still run it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sscarduzio
force-pushed
the
ci/bootstrap-on-master-push
branch
from
September 10, 2026 15:10
ed0db16 to
1f388b4
Compare
coutoPL
requested changes
Sep 10, 2026
coutoPL's point on the review: a stale run can be cancelled instead. That is true and worth having, so it is here. It covers a different case, though. Cancelling helps when the same pull request is pushed twice. It does nothing for three open pull requests, which still queue their own bootstrap sweep each. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
coutoPL
requested changes
Sep 14, 2026
coutoPL
left a comment
Collaborator
There was a problem hiding this comment.
The change is clear and simple, but the PR title and description unecessary makes it mysterious and smart.
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| # A second push to the same pull request makes the first run's result worthless, and this suite |
Collaborator
There was a problem hiding this comment.
The comment violates @docs/dev/style-code.md
Please check other comments added/changed in the PR.
Contributor
Author
|
Superseded by #129 (bootstrap sweep in its own weekly workflow, off pull requests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
master-bootstrap-testsis a 34-version × 2-env matrix — 68 jobs — and it ran on four triggers:docs/dev/branching.mdcase 4 sends every pipeline and workflow change tomaster. Three such PRs moved there today — #120, #122, #126 — and each one queued its own 68 bootstrap jobs behind itself. On #122 the e2e legs it actually needed had all finished:Approved, no failures, and unmergeable for hours — waiting on a sweep of plugins that were released weeks ago.
The change
One clause removed: the pull-request trigger.
Every version in that matrix tests a plugin that is already out, so nothing a pull request changes can change the result. The nightly still sweeps them, a push to
masterstill runs it — that is the moment the released set can actually move — and the manual dispatch is still there when someone wants it.🤖 Generated with Claude Code