Skip to content

Take the bootstrap sweep off pull requests - #127

Closed
sscarduzio wants to merge 2 commits into
masterfrom
ci/bootstrap-on-master-push
Closed

sscarduzio wants to merge 2 commits into
masterfrom
ci/bootstrap-on-master-push

Conversation

@sscarduzio

@sscarduzio sscarduzio commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The problem

master-bootstrap-tests is a 34-version × 2-env matrix — 68 jobs — and it ran on four triggers:

    if: >
      github.event_name == 'schedule' ||
      github.event_name == 'workflow_dispatch' ||
      (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
      (github.event_name == 'pull_request' && github.base_ref == 'master' && ...)

docs/dev/branching.md case 4 sends every pipeline and workflow change to master. Three such PRs moved there today — #120, #122, #126 — and each one queued its own 68 bootstrap jobs behind itself. On #122 the e2e legs it actually needed had all finished:

completed  🔬 E2E Tests (released plugins)  ×13
completed  🧪 E2E Tests (pre-build plugins)
queued     🚀 Bootstrap Tests               ×68

Approved, no failures, and unmergeable for hours — waiting on a sweep of plugins that were released weeks ago.

The change

One clause removed: the pull-request trigger.

    if: >
      github.event_name == 'schedule' ||
      github.event_name == 'workflow_dispatch' ||
      (github.event_name == 'push' && github.ref == 'refs/heads/master')

Every version in that matrix tests a plugin that is already out, so nothing a pull request changes can change the result. The nightly still sweeps them, a push to master still runs it — that is the moment the released set can actually move — and the manual dispatch is still there when someone wants it.

🤖 Generated with Claude Code

@sscarduzio
sscarduzio requested a review from coutoPL September 10, 2026 15:08
@coderabbitai

This comment was marked as off-topic.

The matrix is 34 released versions x 2 envs, so it is 68 jobs.

docs/dev/branching.md case 4 sends every workflow change to master.
Three of them moved there today, and each queued its own 68 bootstrap
jobs behind itself: approved, no failures, unmergeable for hours, while
sweeping plugins that were released weeks ago.

Every version in that matrix tests a plugin that is already out, so
nothing a pull request changes can change the result. The nightly and a
push to master still run it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sscarduzio sscarduzio changed the title Run the bootstrap sweep on master pushes only Take the bootstrap sweep off pull requests Sep 10, 2026
@sscarduzio
sscarduzio force-pushed the ci/bootstrap-on-master-push branch from ed0db16 to 1f388b4 Compare September 10, 2026 15:10
Comment thread .github/workflows/all-e2e-tests.yml
coutoPL's point on the review: a stale run can be cancelled instead. That is true and worth
having, so it is here. It covers a different case, though. Cancelling helps when the same pull
request is pushed twice. It does nothing for three open pull requests, which still queue their
own bootstrap sweep each.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@coutoPL coutoPL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is clear and simple, but the PR title and description unecessary makes it mysterious and smart.

pull_request:
types: [opened, synchronize, reopened]

# A second push to the same pull request makes the first run's result worthless, and this suite

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment violates @docs/dev/style-code.md

Please check other comments added/changed in the PR.

@sscarduzio

Copy link
Copy Markdown
Contributor Author

Superseded by #129 (bootstrap sweep in its own weekly workflow, off pull requests).

@sscarduzio sscarduzio closed this Sep 14, 2026
@sscarduzio
sscarduzio deleted the ci/bootstrap-on-master-push branch September 14, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants