Parse charge-exchange polarization data resolved to a level - #16
Merged
Merged
Conversation
EXFOR writes a quasi-elastic (p,n) measurement to the isobaric analog state with the PAR qualifier and a named residual, e.g. 49-TI-49(P,N)23-V-49,PAR,POL/DA,,ANA. Three things stopped that from parsing. quantity_matches listed PAR variants for dXS/dA but not for the polarization quantities or for XS, so every such subentry was skipped and ExforEntry came back with an empty measurement list and no diagnostic. is_match called reaction.process.upper() on the path where the caller gave neither a residual nor a process, which is reachable from any product-form Reaction, and raised AttributeError instead of reporting a mismatch. Reaction rejected a process given together with a residual, although is_match handles that combination and __str__ already formatted it. The process branch now appends the residual to reaction_string and reaction_latex the way the product branch does. Adds a test module covering entry O0669 (Gosset, Mayer and Escudie, Phys. Rev. C 14, 878 (1976)): all nine targets parse as Ay angular distributions in CM degrees at 22.8 MeV with the analog-state excitation energies of Table I.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXFOR writes a quasi-elastic (p,n) measurement to the isobaric analog state with the PAR qualifier and a named residual, e.g.
49-TI-49(P,N)23-V-49,PAR,POL/DA,,ANA. Three things stopped that from parsing.
quantity_matches listed PAR variants for dXS/dA but not for the polarization quantities or for XS, so every such subentry was skipped and ExforEntry came back with an empty measurement list and no diagnostic.
is_match called reaction.process.upper() on the path where the caller gave neither a residual nor a process, which is reachable from any product-form Reaction, and raised AttributeError instead of reporting a mismatch.
Reaction rejected a process given together with a residual, although is_match handles that combination and str already formatted it. The process branch now appends the residual to reaction_string and reaction_latex the way the product branch does.
Adds a test module covering entry O0669 (Gosset, Mayer and Escudie, Phys. Rev. C 14, 878 (1976)): all nine targets parse as Ay angular distributions in CM degrees at 22.8 MeV with the analog-state excitation energies of Table I.