Avoid full-frame copies in default OpenCV resize#31
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the default OpenCV-backed resize path by avoiding full-frame memory copies, creating lightweight cv::Mat headers over existing ndarray storage and resizing directly into the returned ndarray buffer.
Changes:
- Build zero-copy OpenCV
Matheaders over contiguousArrayView3<u8>input buffers. - Preallocate the output
Array3<u8>and resize directly into its backing memory. - Remove the now-unneeded Mat→ndarray bulk-copy helper from this implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The default resize API copied every input into an owned OpenCV Mat and copied every resized Mat back into a second ndarray allocation. Those memory passes dominated otherwise-fast OpenCV resize calls, especially for large images and batches.
Performance
Median local latency on Apple M3 Max:
The default path is now within a few percent of
batch_resize_images_zero_copy.Validation
cargo test --features opencv,simd(60 passed)