Write resized video frames into final output#33
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Rust/OpenCV video resize path by allocating each output video once and having OpenCV write resized frames directly into the final output buffer, reducing per-frame allocations and extra copies.
Changes:
- Replace the “flatten all frames then reconstruct” approach with per-video output allocation and direct frame writes.
- Create OpenCV
Matheaders that point directly into the destinationndarray::Array4frame buffers. - Keep support for strided frame-axis inputs as long as each individual frame is contiguous.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The video path flattened all frames, used the copy-heavy image API to create one ndarray per resized frame, then allocated each output video and copied every frame into it again. The memory traffic and allocation overhead dominated resize time.
Performance
Median local latency on Apple M3 Max:
The direct path also beat resizing through
batch_resize_images_zero_copyfollowed bynumpy.stack(3.37 ms and 3.07 ms respectively).Validation
cargo test --features opencv,simd(60 passed)