Transfer resize iterator buffers without cloning#34
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the OpenCV-backed Python resize iterator bindings to avoid per-item buffer cloning by transferring ownership of each completed resize buffer directly into the yielded NumPy ndarray, while also making len(iterator) reflect the number of remaining results.
Changes:
- Replace indexed buffer storage with a
VecDequeso iteration canpop_front()and move buffers intondarraywithout cloning. - Update iterator construction paths to initialize/convert buffer storage appropriately.
- Add Python regression coverage for yielded values/shapes, exhaustion behavior, and remaining length reporting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/python_bindings.rs |
Switch ResizeIterator to queue-based ownership transfer and remove cloning during __next__. |
tests/test_python_bindings.py |
Add coverage asserting correct shapes/values, exhaustion, and len(iterator) remaining-count semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ror instead Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
len(iterator)report the number of remaining resultsRoot cause
ResizeIterator.__next__cloned the fullVec<u8>before constructing every ndarray. The API was described as zero-copy, but consuming it performed one avoidable full-output memory copy per image.Performance
Median end-to-end iterator consumption on Apple M3 Max:
Validation
cargo test --features opencv,simd(60 passed)