Make OpenCV performance comparisons equivalent#35
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the competitive performance benchmarks to ensure TSR vs OpenCV comparisons measure equivalent work (removing unrelated color conversions) and to report results neutrally without implying TSR always wins.
Changes:
- Update resize benchmarking to compare TSR against direct
cv2.resize(no RGB↔BGR conversions) and tighten output validation. - Update luminance benchmarking to compare TSR against
cv2.cvtColor(..., COLOR_RGB2GRAY)directly (no extra RGB→BGR step). - Apply the same “equivalent-work” rule and neutral relative-time reporting to the combined pipeline benchmark, plus clarify messaging about loops vs single Python calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cv2.resizewithout unrelated RGB/BGR conversionsCOLOR_RGB2GRAYRoot cause
The competitive benchmarks charged two color conversions to OpenCV resize and an unnecessary RGB-to-BGR conversion to OpenCV luminance. The output then labeled the result a TSR advantage regardless of which implementation won. This obscured the actual resize bottleneck and overstated current performance.
Observed corrected result
On Apple M3 Max with the current main implementation and mixed image shapes:
These are diagnostic point-in-time results, not assertions baked into the tests.
Validation