Skip to content

URI is case insensitive on hostname #3

Description

@reekoheek

You are using url.parse to parse URI (as camel URL terminology known as URI), it is good call reusing common lib.
But the fact is that url.parse return a case insensitive form of hostname.
It makes your example goes wrong,

var obj = require('./myObj');
require('donkey-obj/ObjectResolver').register('myObj',new obj());

as you are registering obj as myObj not as myobj.

I think it is good practice to write URI as lowered-case insensitive value.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions